feat: falls back to FDv1 polling if flag delivery sends fallback header #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Added @keelerm84 as he is privy to the expected behavior. |
tanderson-ld
commented
Apr 25, 2025
packages/shared/sdk-server/src/data_sources/PollingProcessorFDv2.ts
Outdated
Show resolved
Hide resolved
tanderson-ld
commented
Apr 25, 2025
| "@launchdarkly/js-server-sdk-common": "2.10.0", | ||
| "https-proxy-agent": "^5.0.1", | ||
| "launchdarkly-eventsource": "2.0.3" | ||
| "launchdarkly-eventsource": "2.2.0" |
Contributor
Author
There was a problem hiding this comment.
For reviewers: This adds support for getting header from event source.
tanderson-ld
commented
Apr 25, 2025
| const payload = data.payloads[0]; | ||
|
|
||
| switch (payload?.code) { | ||
| switch (payload?.intentCode) { |
Contributor
Author
There was a problem hiding this comment.
For reviewers: Tweak following integration testing with FD team.
tanderson-ld
commented
Apr 25, 2025
| ], | ||
| }, | ||
| }, | ||
| ]); |
Contributor
Author
There was a problem hiding this comment.
For reviewers: id and target don't matter for this case since it is a xfer full.
tanderson-ld
commented
Apr 25, 2025
| }; | ||
|
|
||
| const DEFAULT_POLL_INTERVAL = 30; | ||
| export const DEFAULT_POLL_INTERVAL = 30; |
Contributor
Author
There was a problem hiding this comment.
For reviewers: Used by LDClientImpl for FDv1 fallback polling interval.
keelerm84
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Will validate on holding branch later.
Related issues
SDK-1179
Describe the solution you've provided
Adds FDv1 fallback error type. FDv2 datasources now report that error type if they see the fallback header from the FDv2 endpoints.
Updates FDv2 polling datasource to support being constructed in a FDv1 to FDv2 conversion mode. In that mode, the response from an FDv1 endpoint will be converted to an FDv2 payload and passed through the FDv2 payloadProcessor.
CompositeDataSource now supports an FDv1 fallback synchronizer list. If any datasource reports the FDv1 fallback error, the CompositeDataSource switches to use the fallback synchronizer list.
This PR also contains tweaks to get the holding branch working with the latest contract tests that got some tweaks during recent integration testing.