chore: adds FDv2 contract tests to CI #884
Conversation
|
@launchdarkly/browser size report |
|
@launchdarkly/js-sdk-common size report |
|
@launchdarkly/js-client-sdk-common size report |
|
@launchdarkly/js-client-sdk size report |
tanderson-ld
force-pushed
the
ta/SDK-1318/run-fdv2-contract-tests-ci
branch
from
a713696 to
2f4e25d
Compare
tanderson-ld
requested review from
abarker-launchdarkly and
keelerm84
and removed request for
a team and
abarker-launchdarkly
|
|
||
| this._logger?.debug('Performing initialization request to LaunchDarkly for feature flag data.'); | ||
| this._requestor.requestAllData((err, body) => { | ||
| this._requestor.requestAllData((err, body, headers) => { |
There was a problem hiding this comment.
For reviewers: Realized env id wasn't being piped through in the one shot initializer, so fixed that.
| it('calls callback on success', () => { | ||
| requestor.requestAllData = jest.fn((cb) => cb(undefined, jsonData)); | ||
| initializer.start(mockDataCallback, mockStatusCallback); | ||
| expect(mockDataCallback).toHaveBeenNthCalledWith(1, true, { |
There was a problem hiding this comment.
For reviewers: Realized env id wasn't being piped through in the one shot initializer, so fixed that.
|
bugbot run |
Adds running of FDv2 contract tests in addition to existing FDv1 contract tests.