Skip to content

fix(ai-sdk): Remove Vercel mapping method from LD #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 26, 2025
Merged

fix(ai-sdk): Remove Vercel mapping method from LD #911

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
21e3875
[REL-9248] fix: remove requirement for toVercelAISDK in agent defaults
andrewklatzke Aug 25, 2025
be8794d
[REL-9248] REL-9248: Remove Vercel method from agents
andrewklatzke Aug 26, 2025
f4af733
[REL-9248] remove redundant omit
andrewklatzke Aug 26, 2025
44b97a5
[REL-9248] Update tests to not include mapper
andrewklatzke Aug 26, 2025
5eb8301
[REL-9248] Restore unnecessary removal
andrewklatzke Aug 26, 2025
626ab20
Merge branch 'main' into aklatzke/REL-9248/remove-vercel-method-agents
andrewklatzke Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 2 additions & 103 deletions packages/sdk/server-ai/__tests__/LDAIClientImpl.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
import { LDContext } from '@launchdarkly/js-server-sdk-common';

import { LDAIAgentDefaults } from '../src/api/agents';
import {
LDAIDefaults,
VercelAISDKConfig,
VercelAISDKMapOptions,
VercelAISDKProvider,
} from '../src/api/config';
import { LDAIDefaults } from '../src/api/config';
import { LDAIClientImpl } from '../src/LDAIClientImpl';
import { LDClientMin } from '../src/LDClientMin';

Expand All @@ -17,7 +12,7 @@ const mockLdClient: jest.Mocked<LDClientMin> = {

const testContext: LDContext = { kind: 'user', key: 'test-user' };

it('returns config with interpolated messagess', async () => {
it('returns config with interpolated messages', async () => {
const client = new LDAIClientImpl(mockLdClient);
const key = 'test-flag';
const defaultValue: LDAIDefaults = {
Expand Down Expand Up @@ -156,21 +151,6 @@ it('returns single agent config with interpolated instructions', async () => {
model: { name: 'test', parameters: { name: 'test-model' } },
instructions: 'You are a helpful assistant.',
enabled: true,
toVercelAISDK: <TMod>(
provider: VercelAISDKProvider<TMod> | Record<string, VercelAISDKProvider<TMod>>,
options?: VercelAISDKMapOptions,
): VercelAISDKConfig<TMod> => {
const modelProvider = typeof provider === 'function' ? provider : provider.test;
return {
model: modelProvider('test-model'),
messages: [],
...(options?.nonInterpolatedMessages
? {
messages: options.nonInterpolatedMessages,
}
: {}),
};
},
};

const mockVariation = {
Expand Down Expand Up @@ -205,7 +185,6 @@ it('returns single agent config with interpolated instructions', async () => {
instructions: 'You are a helpful assistant. Your name is John and your score is 42',
tracker: expect.any(Object),
enabled: true,
toVercelAISDK: expect.any(Function),
});

// Verify tracking was called
Expand All @@ -224,21 +203,6 @@ it('includes context in variables for agent instructions interpolation', async (
model: { name: 'test', parameters: { name: 'test-model' } },
instructions: 'You are a helpful assistant.',
enabled: true,
toVercelAISDK: <TMod>(
provider: VercelAISDKProvider<TMod> | Record<string, VercelAISDKProvider<TMod>>,
options?: VercelAISDKMapOptions,
): VercelAISDKConfig<TMod> => {
const modelProvider = typeof provider === 'function' ? provider : provider.test;
return {
model: modelProvider('test-model'),
messages: [],
...(options?.nonInterpolatedMessages
? {
messages: options.nonInterpolatedMessages,
}
: {}),
};
},
};

const mockVariation = {
Expand All @@ -260,21 +224,6 @@ it('handles missing metadata in agent variation', async () => {
model: { name: 'test', parameters: { name: 'test-model' } },
instructions: 'You are a helpful assistant.',
enabled: true,
toVercelAISDK: <TMod>(
provider: VercelAISDKProvider<TMod> | Record<string, VercelAISDKProvider<TMod>>,
options?: VercelAISDKMapOptions,
): VercelAISDKConfig<TMod> => {
const modelProvider = typeof provider === 'function' ? provider : provider.test;
return {
model: modelProvider('test-model'),
messages: [],
...(options?.nonInterpolatedMessages
? {
messages: options.nonInterpolatedMessages,
}
: {}),
};
},
};

const mockVariation = {
Expand All @@ -291,7 +240,6 @@ it('handles missing metadata in agent variation', async () => {
instructions: 'Hello.',
tracker: expect.any(Object),
enabled: false,
toVercelAISDK: expect.any(Function),
});
});

Expand All @@ -303,22 +251,6 @@ it('passes the default value to the underlying client for single agent', async (
provider: { name: 'default-provider' },
instructions: 'Default instructions',
enabled: true,
toVercelAISDK: <TMod>(
provider: VercelAISDKProvider<TMod> | Record<string, VercelAISDKProvider<TMod>>,
options?: VercelAISDKMapOptions,
): VercelAISDKConfig<TMod> => {
const modelProvider =
typeof provider === 'function' ? provider : provider['default-provider'];
return {
model: modelProvider('default-model'),
messages: [],
...(options?.nonInterpolatedMessages
? {
messages: options.nonInterpolatedMessages,
}
: {}),
};
},
};

mockLdClient.variation.mockResolvedValue(defaultValue);
Expand All @@ -331,7 +263,6 @@ it('passes the default value to the underlying client for single agent', async (
provider: defaultValue.provider,
tracker: expect.any(Object),
enabled: false,
toVercelAISDK: expect.any(Function),
});

expect(mockLdClient.variation).toHaveBeenCalledWith(key, testContext, defaultValue);
Expand All @@ -347,21 +278,6 @@ it('returns multiple agents config with interpolated instructions', async () =>
model: { name: 'test', parameters: { name: 'test-model' } },
instructions: 'You are a research assistant.',
enabled: true,
toVercelAISDK: <TMod>(
provider: VercelAISDKProvider<TMod> | Record<string, VercelAISDKProvider<TMod>>,
options?: VercelAISDKMapOptions,
): VercelAISDKConfig<TMod> => {
const modelProvider = typeof provider === 'function' ? provider : provider.test;
return {
model: modelProvider('test-model'),
messages: [],
...(options?.nonInterpolatedMessages
? {
messages: options.nonInterpolatedMessages,
}
: {}),
};
},
},
variables: { topic: 'climate change' },
},
Expand All @@ -371,21 +287,6 @@ it('returns multiple agents config with interpolated instructions', async () =>
model: { name: 'test', parameters: { name: 'test-model' } },
instructions: 'You are a writing assistant.',
enabled: true,
toVercelAISDK: <TMod>(
provider: VercelAISDKProvider<TMod> | Record<string, VercelAISDKProvider<TMod>>,
options?: VercelAISDKMapOptions,
): VercelAISDKConfig<TMod> => {
const modelProvider = typeof provider === 'function' ? provider : provider.test;
return {
model: modelProvider('test-model'),
messages: [],
...(options?.nonInterpolatedMessages
? {
messages: options.nonInterpolatedMessages,
}
: {}),
};
},
},
variables: { style: 'academic' },
},
Expand Down Expand Up @@ -428,7 +329,6 @@ it('returns multiple agents config with interpolated instructions', async () =>
instructions: 'You are a research assistant specializing in climate change.',
tracker: expect.any(Object),
enabled: true,
toVercelAISDK: expect.any(Function),
},
'writing-agent': {
model: {
Expand All @@ -439,7 +339,6 @@ it('returns multiple agents config with interpolated instructions', async () =>
instructions: 'You are a writing assistant with academic style.',
tracker: expect.any(Object),
enabled: true,
toVercelAISDK: expect.any(Function),
},
});

Expand Down
11 changes: 2 additions & 9 deletions packages/sdk/server-ai/src/LDAIClientImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@ export class LDAIClientImpl implements LDAIClient {
defaultValue,
);

const mapper = new LDAIConfigMapper(model, provider, undefined);
const agent: Omit<LDAIAgent, 'toVercelAISDK'> = {
const agent: LDAIAgent = {
tracker,
enabled,
};
Expand All @@ -131,13 +130,7 @@ export class LDAIClientImpl implements LDAIClient {
agent.instructions = this._interpolateTemplate(instructions, allVariables);
}

return {
...agent,
toVercelAISDK: <TMod>(
sdkProvider: VercelAISDKProvider<TMod> | Record<string, VercelAISDKProvider<TMod>>,
options?: VercelAISDKMapOptions | undefined,
): VercelAISDKConfig<TMod> => mapper.toVercelAISDK(sdkProvider, options),
};
return agent;
}

async config(
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/server-ai/src/api/agents/LDAIAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { LDAIConfig } from '../config';
/**
* AI Config agent and tracker.
*/
export interface LDAIAgent extends Omit<LDAIConfig, 'messages'> {
export interface LDAIAgent extends Omit<LDAIConfig, 'messages' | 'toVercelAISDK'> {
/**
* Instructions for the agent.
*/
Expand Down
Loading