Skip to content

Conversation

@jsonbailey
Copy link
Contributor

@jsonbailey jsonbailey commented Nov 6, 2025

Note

Propagates AI config key throughout configs and adds judgeConfigKey to evaluation scores and tracking metadata.

  • API/Types:
    • Add required key to LDAIConfig and surface it in all config variants.
    • Extend EvalScore with optional judgeConfigKey.
  • Config Utils:
    • Update fromFlagValue/to*Config to accept key and include it in configs.
    • Change createDisabledConfig to require key and embed it in returned configs.
  • Client (LDAIClientImpl):
    • Pass key to LDAIConfigUtils.fromFlagValue and createDisabledConfig.
    • Agent multi-fetch now returns configs containing their key.
  • Judge:
    • Include judgeConfigKey in parsed evaluation results based on this._aiConfig.key.
  • Tracking (LDAIConfigTrackerImpl):
    • trackEvalScores sends judgeConfigKey with event context.
  • Tests:
    • Update unit tests to expect key on configs and judgeConfigKey in evals.

Written by Cursor Bugbot for commit 6cf3980. This will update automatically on new commits. Configure here.

@jsonbailey jsonbailey requested a review from a team as a code owner November 6, 2025 22:34
@jsonbailey jsonbailey marked this pull request as draft November 6, 2025 22:36
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 169118 bytes
Compressed size limit: 200000
Uncompressed size: 789399 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 24988 bytes
Compressed size limit: 26000
Uncompressed size: 122411 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 17636 bytes
Compressed size limit: 20000
Uncompressed size: 90259 bytes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 21721 bytes
Compressed size limit: 25000
Uncompressed size: 74698 bytes

@jsonbailey jsonbailey marked this pull request as ready for review November 6, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants