-
Notifications
You must be signed in to change notification settings - Fork 28
feat: Add support for per-context summary events. #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e190058
feat: Add support for per-context summary events.
kinyoklion f64c746
Merge branch 'main' into rlamb/EMSR-326/per-context-summary-events
kinyoklion 5ab516f
Linting
kinyoklion 564bca3
Extend test functionality.
kinyoklion 1c39e0f
Use require.
kinyoklion 3eb3da5
Use canonical JSON as key instead of a hash.
kinyoklion 293b3c3
Comment improvment
kinyoklion 40777fe
Remove hasher from test.
kinyoklion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,6 +89,7 @@ function EventSummarizer() { | |
startDate, | ||
endDate, | ||
features: flagsOut, | ||
kind: 'summary', | ||
}; | ||
}; | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
const canonicalize = require('./canonicalize'); | ||
const EventSummarizer = require('./EventSummarizer'); | ||
|
||
/** | ||
* Construct a multi-event summarizer. This summarizer produces a summary event for each unique context. | ||
* @param {{filter: (context: any) => any}} contextFilter | ||
*/ | ||
function MultiEventSummarizer(contextFilter) { | ||
let summarizers = {}; | ||
let contexts = {}; | ||
|
||
/** | ||
* Summarize the given event. | ||
* @param {{ | ||
* kind: string, | ||
* context?: any, | ||
* }} event | ||
*/ | ||
function summarizeEvent(event) { | ||
if (event.kind === 'feature') { | ||
const key = canonicalize(event.context); | ||
if (!key) { | ||
return; | ||
} | ||
|
||
let summarizer = summarizers[key]; | ||
if (!summarizer) { | ||
summarizers[key] = EventSummarizer(); | ||
summarizer = summarizers[key]; | ||
contexts[key] = event.context; | ||
} | ||
|
||
summarizer.summarizeEvent(event); | ||
} | ||
} | ||
|
||
/** | ||
* Get the summaries of the events that have been summarized. | ||
* @returns {any[]} | ||
*/ | ||
function getSummaries() { | ||
const summarizersToFlush = summarizers; | ||
const contextsForSummaries = contexts; | ||
|
||
summarizers = {}; | ||
contexts = {}; | ||
return Object.entries(summarizersToFlush).map(([key, summarizer]) => { | ||
const summary = summarizer.getSummary(); | ||
summary.context = contextFilter.filter(contextsForSummaries[key]); | ||
return summary; | ||
}); | ||
} | ||
|
||
return { | ||
summarizeEvent, | ||
getSummaries, | ||
}; | ||
} | ||
|
||
module.exports = MultiEventSummarizer; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,148 @@ | ||
const MultiEventSummarizer = require('../MultiEventSummarizer'); | ||
const ContextFilter = require('../ContextFilter'); | ||
|
||
function makeEvent(key, version, variation, value, defaultVal, context) { | ||
return { | ||
kind: 'feature', | ||
creationDate: 1000, | ||
key: key, | ||
version: version, | ||
context: context, | ||
variation: variation, | ||
value: value, | ||
default: defaultVal, | ||
}; | ||
} | ||
|
||
describe('given a multi-event summarizer and context filter', () => { | ||
let summarizer; | ||
let contextFilter; | ||
|
||
beforeEach(() => { | ||
contextFilter = ContextFilter(false, []); | ||
summarizer = MultiEventSummarizer(contextFilter); | ||
}); | ||
|
||
it('creates new summarizer for new context hash', async () => { | ||
const context = { kind: 'user', key: 'user1' }; | ||
const event = { kind: 'feature', context }; | ||
|
||
summarizer.summarizeEvent(event); | ||
|
||
const summaries = await summarizer.getSummaries(); | ||
expect(summaries).toHaveLength(1); | ||
}); | ||
|
||
it('uses existing summarizer for same context hash', async () => { | ||
const context = { kind: 'user', key: 'user1' }; | ||
const event1 = { kind: 'feature', context, value: 'value1' }; | ||
const event2 = { kind: 'feature', context, value: 'value2' }; | ||
|
||
summarizer.summarizeEvent(event1); | ||
summarizer.summarizeEvent(event2); | ||
|
||
const summaries = await summarizer.getSummaries(); | ||
expect(summaries).toHaveLength(1); | ||
}); | ||
|
||
it('ignores non-feature events', async () => { | ||
const context = { kind: 'user', key: 'user1' }; | ||
const event = { kind: 'identify', context }; | ||
|
||
summarizer.summarizeEvent(event); | ||
|
||
const summaries = await summarizer.getSummaries(); | ||
expect(summaries).toHaveLength(0); | ||
}); | ||
|
||
it('handles multiple different contexts', async () => { | ||
const context1 = { kind: 'user', key: 'user1' }; | ||
const context2 = { kind: 'user', key: 'user2' }; | ||
const event1 = { kind: 'feature', context: context1 }; | ||
const event2 = { kind: 'feature', context: context2 }; | ||
|
||
summarizer.summarizeEvent(event1); | ||
summarizer.summarizeEvent(event2); | ||
|
||
const summaries = await summarizer.getSummaries(); | ||
expect(summaries).toHaveLength(2); | ||
}); | ||
|
||
it('automatically clears summaries when summarized', async () => { | ||
const context = { kind: 'user', key: 'user1' }; | ||
const event = { kind: 'feature', context }; | ||
|
||
summarizer.summarizeEvent(event); | ||
|
||
const summariesA = await summarizer.getSummaries(); | ||
const summariesB = await summarizer.getSummaries(); | ||
expect(summariesA).toHaveLength(1); | ||
expect(summariesB).toHaveLength(0); | ||
}); | ||
|
||
it('increments counters for feature events across multiple contexts', async () => { | ||
const context1 = { kind: 'user', key: 'user1' }; | ||
const context2 = { kind: 'user', key: 'user2' }; | ||
|
||
// Events for context1 (using values 100-199) | ||
const event1 = makeEvent('key1', 11, 1, 100, 111, context1); | ||
const event2 = makeEvent('key1', 11, 2, 150, 111, context1); | ||
const event3 = makeEvent('key2', 22, 1, 199, 222, context1); | ||
|
||
// Events for context2 (using values 200-299) | ||
const event4 = makeEvent('key1', 11, 1, 200, 211, context2); | ||
const event5 = makeEvent('key1', 11, 2, 250, 211, context2); | ||
const event6 = makeEvent('key2', 22, 1, 299, 222, context2); | ||
|
||
summarizer.summarizeEvent(event1); | ||
summarizer.summarizeEvent(event2); | ||
summarizer.summarizeEvent(event3); | ||
summarizer.summarizeEvent(event4); | ||
summarizer.summarizeEvent(event5); | ||
summarizer.summarizeEvent(event6); | ||
|
||
const summaries = await summarizer.getSummaries(); | ||
expect(summaries).toHaveLength(2); | ||
|
||
// Sort summaries by context key to make assertions consistent | ||
summaries.sort((a, b) => a.context.key.localeCompare(b.context.key)); | ||
|
||
// Verify first context's summary (user1, values 100-199) | ||
const summary1 = summaries[0]; | ||
summary1.features.key1.counters.sort((a, b) => a.value - b.value); | ||
expect(summary1.features).toEqual({ | ||
key1: { | ||
contextKinds: ['user'], | ||
default: 111, | ||
counters: [ | ||
{ value: 100, variation: 1, version: 11, count: 1 }, | ||
{ value: 150, variation: 2, version: 11, count: 1 }, | ||
], | ||
}, | ||
key2: { | ||
contextKinds: ['user'], | ||
default: 222, | ||
counters: [{ value: 199, variation: 1, version: 22, count: 1 }], | ||
}, | ||
}); | ||
|
||
// Verify second context's summary (user2, values 200-299) | ||
const summary2 = summaries[1]; | ||
summary2.features.key1.counters.sort((a, b) => a.value - b.value); | ||
expect(summary2.features).toEqual({ | ||
key1: { | ||
contextKinds: ['user'], | ||
default: 211, | ||
counters: [ | ||
{ value: 200, variation: 1, version: 11, count: 1 }, | ||
{ value: 250, variation: 2, version: 11, count: 1 }, | ||
], | ||
}, | ||
key2: { | ||
contextKinds: ['user'], | ||
default: 222, | ||
counters: [{ value: 299, variation: 1, version: 22, count: 1 }], | ||
}, | ||
}); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This moved inside the summarizer.