fix(storybook): disable focus trap to fix search box blur issue #1841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Storybook search box immediately losing focus when clicking into it, particularly on stories that have modals/drawers open (like the Legacy Drawer story).
The root cause was that the
FocusTrapcomponent (used by Drawer, Modal, etc.) usesFocusScopefrom@react-aria/focuswithcontain={true}, which traps focus inside the component. When a story renders with a modal/drawer open, clicking the Storybook search box would cause focus to immediately return to the trapped element.The fix wraps story content with
FocusTrapContext.Providerwithcontain: false, which disables focus trapping in Storybook while preserving the behavior in production.Testing approaches
Link to Devin run: https://app.devin.ai/sessions/731006ba17a944138441298d219a7bcc
Requested by: Zach (@zmdavis)