[REL-8210] account for subdirectory in ref filepaths #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were inadverntently ignoring the
subdirectoryoption when creatingFilereps, which led to the tool searching zero files when using the project-leveldirproperty in.launchdarkly/coderefs.yml(There is a workaround to just not specify thedirproperty, but this leads to broken links in gonfalon). The reason for this is that when using thesubdirectoryproperty, theworkspace(this is the root directory thatld-find-code-refssearches under) becomes<root>/subdirectory, but the project-leveldirproperty is relative to the repo root, so the tool would end up looking in<root>/subdirectory/subdirectoryfor files to scan which obviously doesn't exist. The fix here is to remove thesubdirectory(if it exists) from thefile'spathproperty. Existing tests pass; added new tests for thesubdirectoryuse-case.Related Jira issue: REL-8210: Code Refs - Using subdirectory flag creates broken link in LD UI when clicking View source