Skip to content

Conversation

@blaqbern
Copy link
Contributor

@blaqbern blaqbern commented Jul 24, 2025

😩 please let this be the last one 😩

Using the heredoc was creating toil because the syntax is kinda fiddly and workflow_dispatch is only available on main, so I needed to create a PR and get a review for every change. But in the end, using printf is better anyway because it allows for backticks, which bash will try to run if they appear inside an unquoted heredoc. We'll see if the CHANGELOG comes out looking okay, but cursor assures me printf works well for multiline content. 🤞


Related Jira issue: REL-4161: Migrate ld-find-code-refs from Releaser to GHA

@blaqbern blaqbern requested a review from a team as a code owner July 24, 2025 15:18
@launchdarkly-upra launchdarkly-upra bot changed the title switch to printf to allow for backticks in CHANGELOG [REL-4161] switch to printf to allow for backticks in CHANGELOG Jul 24, 2025
@blaqbern blaqbern enabled auto-merge (squash) July 24, 2025 15:26
@blaqbern blaqbern merged commit 9869760 into main Jul 24, 2025
2 checks passed
@blaqbern blaqbern deleted the cblackburn/REL-4161/more-changelog-fixes branch July 24, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants