Skip to content

chore: [REL-4161] Finalize Release GHA #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blaqbern merged 1 commit into from
Jul 25, 2025
Merged

chore: [REL-4161] Finalize Release GHA #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jobs:
LD_RELEASE_VERSION: ${{ inputs.releaseVersion }}
DRY_RUN: ${{ inputs.dryRun || 'false' }}
CHANGELOG_ENTRY: ${{ inputs.changeLog }}
CHANGELOG_JSON: ${{ toJSON(inputs.changeLog) }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ARTIFACT_DIRECTORY: "/tmp/release-artifacts"
steps:
Expand Down Expand Up @@ -77,5 +76,5 @@ jobs:
with:
token: ${{ secrets.GITHUB_TOKEN }}
tag: v${{ inputs.releaseVersion }}
body: ${{ fromJSON(toJSON(inputs.changeLog)) }}
body: ${{ inputs.changeLog }}
artifacts: ${{ env.ARTIFACT_DIRECTORY }}/*
18 changes: 1 addition & 17 deletions scripts/release/commit-and-tag.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,7 @@ tag_exists() (

update_changelog() (
local ts=$(date +"%Y-%m-%d")

echo "raw changelog"
echo "$CHANGELOG_ENTRY"

echo "json changelog"
echo "$CHANGELOG_JSON"

local changelog_body=$(echo "$CHANGELOG_ENTRY" | sed "s/\\n/\n/g")
local changelog_json=$(echo "$CHANGELOG_ENTRY" | jq -r .)

echo "parsed with sed"
echo "$changelog_body"

echo "parsed with jq"
echo "$changelog_json"

local changelog_entry=$(printf "## [%s] - %s\n%s\n" "$LD_RELEASE_VERSION" "$ts" "$changelog_body")
local changelog_entry=$(printf "## [%s] - %s\n%s\n" "$LD_RELEASE_VERSION" "$ts" "$CHANGELOG_ENTRY")

# insert the new changelog entry (followed by empty line) after line 4
# of CHANGELOG.md
Expand Down
Loading