chore: [REL-4161] pass homebrew token through Makefile to Goreleaser #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
launchdarkly-upra
bot
changed the title
blaqbern
changed the title
sheldonmartin
approved these changes
Aug 5, 2025
blaqbern
deleted the
cblackburn/REL-4161/ensure-goreleaser-has-access-to-homebrew-env-var
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay, I think I finally understand why Goreleaser wasn't able to find the HOMEBREW_GH_TOKEN. Setting it as an env var on the GHA is not enough, it needs to be explicitly passed to the Makefile, and then passed to the Goreleaser command.
Related Jira issue: REL-4161: Migrate ld-find-code-refs from Releaser to GHA