Merged
Conversation
All resources should be created using the fullname, allowing for multiple deployments of the same chart within the same namespace. fixes #85
tanderson-ld
approved these changes
Jan 29, 2026
Suhaibshah22
approved these changes
Jan 30, 2026
Suhaibshah22
left a comment
Suhaibshah22
left a comment
There was a problem hiding this comment.
The fix works as intended.
I pulled the chart from this branch and deployed it in my cluster and I can see two separate config maps in the same namespace as expected.
Member
Author
|
Thank you @Suhaibshah22 for confirming the fix! |
keelerm84
pushed a commit
that referenced
this pull request
Jan 30, 2026
🤖 I have created a release *beep* *boop* --- ## [3.4.1](3.4.0...3.4.1) (2026-01-30) ### Bug Fixes * Use fullname for config resources ([#86](#86)) ([b71f668](b71f668)), closes [#85](#85) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All resources should be created using the fullname, allowing for
multiple deployments of the same chart within the same namespace.
fixes #85