Skip to content

Conversation

@dmashuda
Copy link
Contributor

@dmashuda dmashuda commented Dec 4, 2024

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Provide links to any issues in this repository or elsewhere relating to this pull request.

Describe the solution you've provided

Provide a clear and concise description of what you expect to happen.

Add options to sync environment at dev-server startup:

Example command:

ldcli dev-server start --project default --source staging --project default --source staging --override '{"ab.testing": true, "sometotherflag": 10}'

Provide a clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context about the pull request here.

@dmashuda dmashuda marked this pull request as draft December 4, 2024 21:45
@dmashuda dmashuda changed the title Add options for start and sync FEAT: Add options to sync environment at dev-server startup Dec 5, 2024
@dmashuda dmashuda self-assigned this Dec 5, 2024
@dmashuda dmashuda requested a review from mike-zorn December 5, 2024 19:40
@dmashuda dmashuda marked this pull request as ready for review December 5, 2024 19:41
@dmashuda dmashuda changed the title FEAT: Add options to sync environment at dev-server startup feat: Add options to sync environment at dev-server startup Dec 5, 2024
Copy link

@mike-zorn mike-zorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the doc issue, LGTM! Up to you if you wanna address the nitpick feedback on the method name.

@dmashuda dmashuda merged commit a9f61c5 into main Dec 9, 2024
9 checks passed
@dmashuda dmashuda deleted the danielmashuda/FUN-358-start-n-sync branch December 9, 2024 16:24
@CodeOfficer
Copy link
Contributor

Love this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants