fix: Delete overrides that are no longer relevant after a project is synced#544
Merged
mike-zorn merged 2 commits intolaunchdarkly:mainfrom Jun 2, 2025
Merged
fix: Delete overrides that are no longer relevant after a project is synced#544mike-zorn merged 2 commits intolaunchdarkly:mainfrom
mike-zorn merged 2 commits intolaunchdarkly:mainfrom
Conversation
ajworkos
changed the title
mike-zorn
approved these changes
Jun 2, 2025
mike-zorn
left a comment
mike-zorn
left a comment
There was a problem hiding this comment.
This is great! Thanks for the submission and for taking the time to make it such a good one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
#541
Describe the solution you've provided
When a project is being updated, any override that does not have a corresponding variation entry is deleted.
Describe alternatives you've considered
N/A
Additional context
See #541, when a flag is deleted in launch darkly that has been overridden locally, and the project is synced, the override remains and cannot be deleted through the CLI/REST API.
Before
Screenshare.-.2025-05-31.8_13_39.PM.mp4
After
Screenshare.-.2025-05-31.8_15_23.PM.mp4