Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,12 @@ internal static void AddLaunchDarklyObservabilityWithConfig(this IServiceCollect
options.WithCommonLaunchDarklyLoggingExport(config);
});
config.ExtendedLoggerConfiguration?.Invoke(logging);
}).WithMetrics(metrics =>
}, options =>
{
options.IncludeFormattedMessage = true;
config.ExtendedLoggerOptionsConfiguration?.Invoke(options);
})
.WithMetrics(metrics =>
{
metrics
.WithCommonLaunchDarklyConfig(config, resourceBuilder)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,13 @@ internal ObservabilityPluginBuilder(IServiceCollection services) : base()
"Service collection cannot be null when creating an ObservabilityPlugin builder.");
}

public ObservabilityPluginBuilder WithExtendedLoggerConfiguration(Action<LoggerProviderBuilder> extendedLoggerConfiguration, Action<OpenTelemetryLoggerOptions> configureLoggerOptions)
{
WithExtendedLoggerConfiguration(extendedLoggerConfiguration);
ConfigureLoggerOptions = configureLoggerOptions;
return this;
}

/// <summary>
/// Build an <see cref="ObservabilityPlugin"/> instance with the configured settings.
/// </summary>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ public static void AddLaunchDarklyLogging(this ILoggingBuilder loggingBuilder, O
options.SetResourceBuilder(CommonOtelOptions.GetResourceBuilder(config))
.AddProcessor(new SamplingLogProcessor(CommonOtelOptions.GetSampler(config)))
.AddOtlpExporter(exportOptions => { exportOptions.WithCommonLaunchDarklyLoggingExport(config); });

config.ExtendedLoggerConfiguration?.Invoke(options);
});
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ public class BaseBuilder<TBuilder> where TBuilder : BaseBuilder<TBuilder>
private Action<TracerProviderBuilder> _extendedTracerConfiguration;
private Action<LoggerBuilderType> _extendedLoggerConfiguration;
private Action<MeterProviderBuilder> _extendedMeterConfiguration;
#if !NETFRAMEWORK
protected Action<OpenTelemetryLoggerOptions> ConfigureLoggerOptions;
#endif

protected BaseBuilder()
{
Expand Down Expand Up @@ -265,7 +268,11 @@ internal ObservabilityConfig BuildConfig(string sdkKey)
sdkKey,
_extendedTracerConfiguration,
_extendedLoggerConfiguration,
_extendedMeterConfiguration);
_extendedMeterConfiguration
#if !NETFRAMEWORK
, ConfigureLoggerOptions
#endif
);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ namespace LaunchDarkly.Observability
{
#if NETFRAMEWORK
using LoggerBuilderType = OpenTelemetryLoggerOptions;

#else
using LoggerBuilderType = LoggerProviderBuilder;
#endif
Expand Down Expand Up @@ -60,6 +61,13 @@ public class ObservabilityConfig
/// </summary>
public Action<LoggerBuilderType> ExtendedLoggerConfiguration { get; }

#if !NETFRAMEWORK
/// <summary>
/// Function which extends the options of the logger provider.
/// </summary>
public Action<OpenTelemetryLoggerOptions> ExtendedLoggerOptionsConfiguration { get; }
#endif

/// <summary>
/// Function which extends the configuration of the meter provider.
/// </summary>
Expand All @@ -75,6 +83,9 @@ internal ObservabilityConfig(
Action<TracerProviderBuilder> extendedTracerConfiguration,
Action<LoggerBuilderType> extendedLoggerConfiguration,
Action<MeterProviderBuilder> extendedMeterConfiguration
#if !NETFRAMEWORK
, Action<OpenTelemetryLoggerOptions> extendedLoggerOptionConfiguration
#endif
)
{
OtlpEndpoint = otlpEndpoint;
Expand All @@ -86,6 +97,9 @@ Action<MeterProviderBuilder> extendedMeterConfiguration
ExtendedTracerConfiguration = extendedTracerConfiguration;
ExtendedLoggerConfiguration = extendedLoggerConfiguration;
ExtendedMeterConfiguration = extendedMeterConfiguration;
#if !NETFRAMEWORK
ExtendedLoggerOptionsConfiguration = extendedLoggerOptionConfiguration;
#endif
}

/// <summary>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
using NUnit.Framework;
using System;
using Microsoft.Extensions.DependencyInjection;
#if !NETFRAMEWORK
using OpenTelemetry.Logs;
#endif

namespace LaunchDarkly.Observability.Test
{
Expand Down Expand Up @@ -115,5 +118,75 @@ public void Build_PrefersExplicitServiceName_OverEnvironmentVariable()
Environment.SetEnvironmentVariable(EnvironmentVariables.OtelServiceName, originalValue);
}
}

#if !NETFRAMEWORK
[Test]
public void WithExtendedLoggerConfiguration_WithBothParameters_SetsConfigurationCorrectly()
{
Action<LoggerProviderBuilder> loggerConfig = _ => { };
Action<OpenTelemetryLoggerOptions> loggerOptions = _ => { };

var pluginBuilder = ObservabilityPlugin.Builder(_services)
.WithExtendedLoggerConfiguration(loggerConfig, loggerOptions);

var plugin = pluginBuilder.Build();

Assert.That(plugin, Is.Not.Null);
Assert.That(plugin, Is.InstanceOf<ObservabilityPlugin>());
}

[Test]
public void WithExtendedLoggerConfiguration_WithNullLoggerConfiguration_AcceptsNullValue()
{
Action<OpenTelemetryLoggerOptions> loggerOptions = _ => { };

var pluginBuilder = ObservabilityPlugin.Builder(_services)
.WithExtendedLoggerConfiguration(null, loggerOptions);

var plugin = pluginBuilder.Build();

Assert.That(plugin, Is.Not.Null);
Assert.That(plugin, Is.InstanceOf<ObservabilityPlugin>());
}

[Test]
public void WithExtendedLoggerConfiguration_WithNullLoggerOptions_AcceptsNullValue()
{
Action<LoggerProviderBuilder> loggerConfig = _ => { };

var pluginBuilder = ObservabilityPlugin.Builder(_services)
.WithExtendedLoggerConfiguration(loggerConfig, null);

var plugin = pluginBuilder.Build();

Assert.That(plugin, Is.Not.Null);
Assert.That(plugin, Is.InstanceOf<ObservabilityPlugin>());
}

[Test]
public void WithExtendedLoggerConfiguration_WithBothParametersNull_AcceptsNullValues()
{
var pluginBuilder = ObservabilityPlugin.Builder(_services)
.WithExtendedLoggerConfiguration(null, null);

var plugin = pluginBuilder.Build();

Assert.That(plugin, Is.Not.Null);
Assert.That(plugin, Is.InstanceOf<ObservabilityPlugin>());
}

[Test]
public void WithExtendedLoggerConfiguration_ReturnsBuilderInstance()
{
Action<LoggerProviderBuilder> loggerConfig = _ => { };
Action<OpenTelemetryLoggerOptions> loggerOptions = _ => { };

var result = ObservabilityPlugin.Builder(_services)
.WithExtendedLoggerConfiguration(loggerConfig, loggerOptions);

Assert.That(result, Is.Not.Null);
Assert.That(result, Is.InstanceOf<ObservabilityPlugin.ObservabilityPluginBuilder>());
}
#endif
}
}
Loading