feat: O11Y-576 / O11Y-544 - Added disk buffering to cache signals#249
Merged
agrognetti merged 3 commits intomainfrom Oct 4, 2025
Merged
feat: O11Y-576 / O11Y-544 - Added disk buffering to cache signals#249agrognetti merged 3 commits intomainfrom
agrognetti merged 3 commits intomainfrom
Conversation
tanderson-ld
approved these changes
Oct 3, 2025
CustomSampler: The log sampling logic was fixed to avoid continuing to evaluate a log in search of a match when the config severityText or message are not null but the log severityText or message values are null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A DiskBufferingCache was set on OtelRumConfig to cache signals (metrics, traces, logs) and avoid data loss when the Android client has no connection.
CustomSampler: The log sampling logic was fixed to avoid continuing to evaluate a log in search of a match when the config severityText or message are not null but the log severityText or message values are null.
How did you test this change?
Unit tests
Are there any deployment considerations?
No
Note
Enables disk buffering in Otel RUM config and updates log sampling to not match when message/severity are absent, with tests and e2e test harness support.
OtelRumConfig.setDiskBufferingConfig(DiskBufferingConfig.create(...)), toggled byisAnySignalEnabled(options)andoptions.debug.isAnySignalEnabledand minor formatting cleanup.CustomSampler.matchesLogConfigto treat missingseverityText/messageas non-matches.message/severityand rename one test for clarity.io.opentelemetry.android:coreand callSignalFromDiskExporter.resetForTesting()inTestApplication.onTerminate()to support disk buffering tests.Written by Cursor Bugbot for commit ad1b187. This will update automatically on new commits. Configure here.