Skip to content

feat: O11Y-576 / O11Y-544 - Added disk buffering to cache signals#249

Merged
agrognetti merged 3 commits intomainfrom
agrognetti/O11Y-576
Oct 4, 2025
Merged

feat: O11Y-576 / O11Y-544 - Added disk buffering to cache signals#249
agrognetti merged 3 commits intomainfrom
agrognetti/O11Y-576

Conversation

@agrognetti
Copy link
Contributor

@agrognetti agrognetti commented Sep 30, 2025

Summary

A DiskBufferingCache was set on OtelRumConfig to cache signals (metrics, traces, logs) and avoid data loss when the Android client has no connection.

CustomSampler: The log sampling logic was fixed to avoid continuing to evaluate a log in search of a match when the config severityText or message are not null but the log severityText or message values are null.

How did you test this change?

Unit tests

Are there any deployment considerations?

No


Note

Enables disk buffering in Otel RUM config and updates log sampling to not match when message/severity are absent, with tests and e2e test harness support.

  • Observability SDK (Android)
    • Enable disk buffering via OtelRumConfig.setDiskBufferingConfig(DiskBufferingConfig.create(...)), toggled by isAnySignalEnabled(options) and options.debug.
    • Add helper isAnySignalEnabled and minor formatting cleanup.
  • Sampling
    • Tighten CustomSampler.matchesLogConfig to treat missing severityText/message as non-matches.
    • Update tests to cover non-match cases for null or mismatched message/severity and rename one test for clarity.
  • E2E Test App
    • Add dependency io.opentelemetry.android:core and call SignalFromDiskExporter.resetForTesting() in TestApplication.onTerminate() to support disk buffering tests.

Written by Cursor Bugbot for commit ad1b187. This will update automatically on new commits. Configure here.

@agrognetti agrognetti requested a review from a team as a code owner September 30, 2025 18:50
cursor[bot]

This comment was marked as outdated.

@agrognetti agrognetti changed the title Added disk buffering to cache signals feat: O11Y-576 - Added disk buffering to cache signals Sep 30, 2025
CustomSampler: The log sampling logic was fixed to avoid continuing to evaluate a log in search of a match when the config severityText or message are not null but the log severityText or message values are null.
@agrognetti agrognetti changed the title feat: O11Y-576 - Added disk buffering to cache signals feat: O11Y-576 / O11Y-544 - Added disk buffering to cache signals Oct 4, 2025
@agrognetti agrognetti merged commit 6c0092a into main Oct 4, 2025
23 checks passed
@agrognetti agrognetti deleted the agrognetti/O11Y-576 branch October 4, 2025 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants