-
Notifications
You must be signed in to change notification settings - Fork 3
fix: H.stop should stop otel exporters #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntiner1
approved these changes
Oct 16, 2025
7e8e32f to
91a90de
Compare
Merged
Vadman97
pushed a commit
that referenced
this pull request
Oct 30, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>observability: 0.4.7</summary> ## [0.4.7](observability-0.4.6...observability-0.4.7) (2025-10-30) ### Dependencies * The following workspace dependencies were updated * dependencies * highlight.run bumped to 9.22.4 </details> <details><summary>session-replay: 0.4.7</summary> ## [0.4.7](session-replay-0.4.6...session-replay-0.4.7) (2025-10-30) ### Dependencies * The following workspace dependencies were updated * dependencies * highlight.run bumped to 9.22.4 </details> <details><summary>highlight.run: 9.22.4</summary> ## [9.22.4](highlight.run-9.22.3...highlight.run-9.22.4) (2025-10-30) ### Bug Fixes * correctly report version on webjs otel data ([#278](#278)) ([f1a2c74](f1a2c74)) * H.stop should stop otel exporters ([#273](#273)) ([2e5e96b](2e5e96b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Publish observability 0.4.7, session-replay 0.4.7, and highlight.run 9.22.4 with dependency bumps and bug-fix notes. > > - **Releases**: > - `sdk/@launchdarkly/observability` → `0.4.7` > - deps: `highlight.run` → `9.22.4` > - `sdk/@launchdarkly/session-replay` → `0.4.7` > - deps: `highlight.run` → `9.22.4` > - `sdk/highlight-run` → `9.22.4` > - bug fixes: correct webjs otel version reporting; ensure `H.stop` stops otel exporters > - **Changelogs/Manifest**: Update `CHANGELOG.md` entries and `.release-please-manifest.json` to reflect versions. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4e1f559. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure that
H.stop()shuts down OpenTelemetry exporters.How did you test this change?
H.stop() now stops otel instrumentation; tested via e2e nextjs app
extensive testing of start-after-stop


Are there any deployment considerations?
no
Note
Ensure
H.stop()andLDObserve.stop()fully shut down OTEL providers; switch metrics togetMeter()with guards and reset instrument caches; add test buttons and session replay config tweaks.getMeter()for metrics (createGauge/Counter/Histogram/UpDownCounter) with null-guards insdk/highlight-run/src/client/index.tsx.setupBrowserTracing, clear metric instrument caches to bind to the new meter.stopRecording, callshutdown()to stop OTEL providers.sdk/highlight-run/src/client/otel/index.ts, prevent double-initialization if tracer or meter already exists.shutdown()to asynchronously shut down tracer and meter providers and unset them.getMeter(); remove directmetrics.getMeter(BROWSER_METER_NAME)usage.getMeter()usage and cache resets insdk/highlight-run/src/sdk/observe.ts.shutdown()instop().H.recordMetric,H.start,H.stopine2e/nextjs/.../highlight-buttons.tsx.e2e/react-router/src/ldclientLazy.tsx.Written by Cursor Bugbot for commit b092635. This will update automatically on new commits. Configure here.