Skip to content

fix: correctly report version on webjs otel data #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vadman97 merged 4 commits into from
Oct 30, 2025
Merged

fix: correctly report version on webjs otel data #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c6454b
fix: correctly report version on webjs otel data
Vadman97 Oct 29, 2025
2254ede
no default version
Vadman97 Oct 29, 2025
d5812ef
add version
Vadman97 Oct 29, 2025
6d556fd
add version
Vadman97 Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions e2e/react-router/src/ldclientLazy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const observabilitySettings: ConstructorParameters<typeof Observability>[0] = {
recordHeadersAndBody: true,
},
serviceName: 'ryan-test',
version: 'my-version',
backendUrl: 'http://localhost:8082/public',
otel: {
otlpEndpoint: 'http://localhost:4318',
Expand All @@ -21,6 +22,7 @@ const sessionReplaySettings: ConstructorParameters<typeof SessionReplay>[0] = {
inlineStylesheet: true,
privacySetting: 'none',
serviceName: 'ryan-test',
version: 'my-version',
backendUrl: 'http://localhost:8082/public',
manualStart: true,
enableCanvasRecording: true,
Expand Down
2 changes: 2 additions & 0 deletions sdk/highlight-run/src/client/otel/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ export type BrowserTracingConfig = {
environment?: string
networkRecordingOptions?: NetworkRecordingOptions
serviceName?: string
serviceVersion?: string
tracingOrigins?: boolean | (string | RegExp)[]
urlBlocklist?: string[]
eventNames?: EventName[]
Expand Down Expand Up @@ -142,6 +143,7 @@ export const setupBrowserTracing = (
const resource = new Resource({
[SemanticAttributes.ATTR_SERVICE_NAME]:
config.serviceName ?? 'highlight-browser',
[SemanticAttributes.ATTR_SERVICE_VERSION]: config.serviceVersion,
'deployment.environment.name': environment,
'highlight.project_id': config.projectId,
[SemanticAttributes.ATTR_USER_AGENT_ORIGINAL]: navigator.userAgent,
Expand Down
1 change: 1 addition & 0 deletions sdk/highlight-run/src/sdk/observe.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ export class ObserveSDK implements Observe {
: undefined,
tracingOrigins: this._options?.tracingOrigins,
serviceName: this._options?.serviceName ?? 'browser',
serviceVersion: this._options?.version,
instrumentations: this._options?.otel?.instrumentations,
eventNames: this._options?.otel?.eventNames,
},
Expand Down
Loading