refactor: OY11-846 - Add Session Replay plugin #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the Session Replay plugin for the LaunchDarkly Android SDK, allowing session recording as an extension to Observability. Refactors plugin and instrumentation management by adding PluginManager and InstrumentationContributor, removes direct instrumentation from Options, and updates ObservabilityClient and InstrumentationManager to support plugin-contributed instrumentations. Updates documentation and sample usage to reflect the new plugin architecture. Also bumps launchdarkly-android-client-sdk dependency to 5.9.2.
e2e/android/app/src/main/java/com/example/androidobservability/BaseApplication.kt
Show resolved
Hide resolved
Renamed and relocated PluginManager from the client package to the plugin package for better organization.
abelonogov-ld
requested changes
Dec 12, 2025
Contributor
abelonogov-ld
left a comment
abelonogov-ld
left a comment
There was a problem hiding this comment.
There are missing step:
backendUrl and logAdapter are not being passed into ReplayInstrumentation from Obs module.
e2e/android/app/src/main/java/com/example/androidobservability/BaseApplication.kt
Show resolved
Hide resolved
…onContributorManager - Remove PluginManager and introduce InstrumentationContributorManager to register/retrieve contributors per LDClient. - Update Observability to collect instrumentations from registered contributors. - Add ObservabilityContext and expose it via LDObserve.context so dependent plugins (e.g. Session Replay) can access config/dependencies. - Update SessionReplay, ReplayInstrumentation, and ReplayOptions to follow the new flow. - Update tests: add InstrumentationContributorManagerTest and adjust SessionReplayTest to use LDObserve.context/Timber.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...rvability-android/lib/src/main/kotlin/com/launchdarkly/observability/plugin/Observability.kt
Show resolved
Hide resolved
...rvability-android/lib/src/main/kotlin/com/launchdarkly/observability/plugin/Observability.kt
Show resolved
Hide resolved
...rvability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/SessionReplay.kt
Outdated
Show resolved
Hide resolved
...rvability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/SessionReplay.kt
Show resolved
Hide resolved
...b/src/main/kotlin/com/launchdarkly/observability/plugin/InstrumentationContributorManager.kt
Show resolved
Hide resolved
abelonogov-ld
approved these changes
Dec 15, 2025
abelonogov-ld
added a commit
that referenced
this pull request
Dec 16, 2025
* main: chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321) feat: sanitize URLs + semantic conventions for header attributes (#317) refactor: introduce granular ObservabilityOptions (#323) refactor: OY11-846 - Add Session Replay plugin (#313) # Conflicts: # sdk/@launchdarkly/observability-android/lib/src/test/kotlin/com/launchdarkly/observability/replay/RRwebGraphQLReplayLogExporterTest.kt
abelonogov-ld
added a commit
that referenced
this pull request
Dec 16, 2025
* main: feat: Limit accumulating canvas buffer (#322) chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321) feat: sanitize URLs + semantic conventions for header attributes (#317) refactor: introduce granular ObservabilityOptions (#323) refactor: OY11-846 - Add Session Replay plugin (#313) chore: upgrade react-server-dom-webpack to 19.0.3 (#320) chore: release main (#319) feat: enhance Web Vitals telemetry with semantic attributes (#316) chore: release main (#318) fix: Android - Remove Disk Buffering (#315) chore: readme update with real examples (#314)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How did you test this change?
Note
Adds Session Replay plugin and refactors Observability to install plugin-contributed instrumentations; updates docs, sample app, and bumps dependencies.
SessionReplayplugin withReplayInstrumentationandReplayOptions; integrates viaInstrumentationContributor.onPluginsReady, exposesLDObserve.context, and installs instrumentations fromInstrumentationContributorManager.Options.instrumentations; addObservabilityContextfor cross-plugin sharing.ObservabilityClient/InstrumentationManageracceptList<LDExtendedInstrumentation>and route logs viaRoutingLogRecordProcessor.InstrumentationContributorinterface andInstrumentationContributorManagerfor per-LDClientregistration.SessionReplayafterObservabilityinLDConfigsetup.launchdarkly-android-client-sdkto5.10.0; upgrade Kotlin to2.2.0.Written by Cursor Bugbot for commit 4bb166e. This will update automatically on new commits. Configure here.