feat: enhance Web Vitals telemetry with semantic attributes #316
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds some SemConv attributes for different parts o the URL. This will be used to build UI for breaking down web vitals performance across different pages in an app. Also migrates the
groupattribute to pathname rather than the full href, lowering its cardinality.How did you test this change?
Click tested the E2E react router example and checked things were landing in Clickhouse correctly.
Are there any deployment considerations?
N/A
Note
Adds OTel semantic URL attributes to Web Vitals gauges and groups them by pathname instead of full URL.
sdk/highlight-run/src/sdk/observe.ts):ATTR_URL_FULL,ATTR_URL_PATH,ATTR_SERVER_ADDRESS.window.location.hreftowindow.location.pathnamefor Web Vitals metrics.Written by Cursor Bugbot for commit a6ff35a. This will update automatically on new commits. Configure here.