Skip to content

Conversation

@abelonogov-ld
Copy link
Contributor

@abelonogov-ld abelonogov-ld commented Dec 15, 2025

Summary

RRWeb Canvas is being updated by draw commands and they all kept in the browser memory. Pr makes SR to reset this Canvas cache by pushing FullSnapshot after 10mb of canvas payloads


Note

Track accumulated canvas draw size with a configurable limit to force full snapshots; serialize exports and update tests.

  • Replay exporter (RRwebGraphQLReplayLogExporter):
    • Add configurable canvasBufferLimit and canvasDrawEntourage (defaults ~10MB, 300 bytes) and track generatingCanvasSize/pushedCanvasSize.
    • Trigger full snapshot when accumulated canvas size exceeds limit, in addition to session/size changes.
    • Update size accounting on incremental and full events; flush size after pushPayload.
    • Ensure single-threaded export with Mutex around export to protect counters.
  • Tests:
    • Add test canvas buffer limit validating full snapshot when limit exceeded.
    • Pass buffer config into exporter setup; adjust verifiers to accept expected counts.
    • Minor test cleanups/wording tweaks.

Written by Cursor Bugbot for commit 2117644. This will update automatically on new commits. Configure here.

@abelonogov-ld abelonogov-ld requested a review from a team as a code owner December 15, 2025 17:16
@abelonogov-ld abelonogov-ld changed the title feat: Limit accumulating canvas buffe feat: Limit accumulating canvas buffer Dec 15, 2025
@abelonogov-ld abelonogov-ld force-pushed the andrey/limit-acc-canvas-buffer branch from 119e4f2 to c6c6dc4 Compare December 15, 2025 23:56
* main:
  chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321)
  feat: sanitize URLs + semantic conventions for header attributes (#317)
  refactor: introduce granular ObservabilityOptions (#323)
  refactor: OY11-846 - Add Session Replay plugin (#313)

# Conflicts:
#	sdk/@launchdarkly/observability-android/lib/src/test/kotlin/com/launchdarkly/observability/replay/RRwebGraphQLReplayLogExporterTest.kt
@abelonogov-ld abelonogov-ld merged commit 72f2592 into main Dec 16, 2025
22 checks passed
@abelonogov-ld abelonogov-ld deleted the andrey/limit-acc-canvas-buffer branch December 16, 2025 16:13
abelonogov-ld added a commit that referenced this pull request Dec 16, 2025
* main:
  feat: Limit accumulating canvas buffer (#322)
  chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321)
  feat: sanitize URLs + semantic conventions for header attributes (#317)
  refactor: introduce granular ObservabilityOptions (#323)
  refactor: OY11-846 - Add Session Replay plugin (#313)
  chore: upgrade react-server-dom-webpack to 19.0.3 (#320)
  chore: release main (#319)
  feat: enhance Web Vitals telemetry with semantic attributes (#316)
  chore: release main (#318)
  fix: Android - Remove Disk Buffering (#315)
  chore: readme update with real examples (#314)
Vadman97 pushed a commit that referenced this pull request Dec 18, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>launchdarkly-observability-android: 0.20.0</summary>

##
[0.20.0](launchdarkly-observability-android-0.19.1...launchdarkly-observability-android-0.20.0)
(2025-12-18)


### Features

* Android SR Identify support
([#330](#330))
([a421812](a421812))
* Graphql client memory optimization
([#325](#325))
([f199e2d](f199e2d))
* Gzip compression for Graphql request body
([#328](#328))
([d862a15](d862a15))
* Limit accumulating canvas buffer
([#322](#322))
([72f2592](72f2592))
</details>

<details><summary>observability: 0.4.11</summary>

##
[0.4.11](observability-0.4.10...observability-0.4.11)
(2025-12-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * highlight.run bumped to 9.25.0
</details>

<details><summary>session-replay: 0.4.11</summary>

##
[0.4.11](session-replay-0.4.10...session-replay-0.4.11)
(2025-12-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * highlight.run bumped to 9.25.0
</details>

<details><summary>highlight.run: 9.25.0</summary>

##
[9.25.0](highlight.run-9.24.0...highlight.run-9.25.0)
(2025-12-18)


### Features

* sanitize URLs + semantic conventions for header attributes
([#317](#317))
([417b4b8](417b4b8))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Release Android SDK 0.20.0 with multiple performance/features, bump
highlight.run to 9.25.0, and update web packages
(@launchdarkly/observability, @launchdarkly/session-replay) to 0.4.11
consuming the new dependency.
> 
> - **Releases**:
>   - `sdk/@launchdarkly/observability-android` → `0.20.0`
> - Features: Android SR Identify support, GraphQL client memory
optimizations, Gzip GraphQL request bodies, limit accumulating canvas
buffer.
>   - `sdk/highlight-run` → `9.25.0`
> - Features: URL sanitization + semantic conventions for header
attributes.
>   - `sdk/@launchdarkly/observability` → `0.4.11`
>     - Dependency: `highlight.run` bumped to `9.25.0`.
>   - `sdk/@launchdarkly/session-replay` → `0.4.11`
>     - Dependency: `highlight.run` bumped to `9.25.0`.
> - **Version metadata**:
> - Updated versions in `.release-please-manifest.json`,
`package.json`s, and Android `gradle.properties`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
68d9f0b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
abelonogov-ld added a commit that referenced this pull request Jan 13, 2026
* main: (29 commits)
  chore: release main (#344)
  feat: Android double masking with frame drop (#342)
  chore: update LaunchDarkly SDK dependencies (#336)
  chore: Android SR - cleanup privacy settings (#341)
  chore: release main (#340)
  feat: Added privacy options: maskViews, maskXMLViewIds, maskImageViews (#339)
  test: O11Y-908 - Add Android CI workflows (#337)
  chore: release main (#335)
  feat: publish umd for broser environments (#334)
  chore: release main (#333)
  feat: Pause and resume replay capture on app background/foreground (#329)
  fix: Fix compose coordinate offset.  (#331)
  chore: release main (#324)
  fix(highlight.run): correct privacy masking for empty strings (#332)
  feat: Android SR Identify support  (#330)
  feat: Gzip compression for Graphql request body (#328)
  docs: Update readme with options refactor (#326)
  feat: Graphql client memory optimization (#325)
  feat: Limit accumulating canvas buffer (#322)
  chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants