refactor: introduce granular ObservabilityOptions #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the monolithic `Options` data class into a more granular `ObservabilityOptions` structure. This change introduces nested classes for `TracesApi`, `MetricsApi`, and `Instrumentations`, and replaces boolean flags (`disableLogs`, `disableTraces`, `disableMetrics`, `disableErrorTracking`). - `disableLogs` is replaced by `logsApiLevel`, which allows filtering logs by severity. - `disableTraces` and `disableErrorTracking` are replaced by `tracesApi` to control spans and errors separately. - `disableMetrics` is replaced by the `metricsApi` object. - Automatic instrumentations like crash reporting and launch time can now be configured under the `instrumentations` property.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
e2e/android/app/src/test/java/com/example/androidobservability/DisablingConfigOptionsE2ETest.kt
Show resolved
Hide resolved
...-android/lib/src/main/kotlin/com/launchdarkly/observability/client/InstrumentationManager.kt
Show resolved
Hide resolved
abelonogov-ld
approved these changes
Dec 15, 2025
abelonogov-ld
added a commit
that referenced
this pull request
Dec 16, 2025
* main: chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321) feat: sanitize URLs + semantic conventions for header attributes (#317) refactor: introduce granular ObservabilityOptions (#323) refactor: OY11-846 - Add Session Replay plugin (#313) # Conflicts: # sdk/@launchdarkly/observability-android/lib/src/test/kotlin/com/launchdarkly/observability/replay/RRwebGraphQLReplayLogExporterTest.kt
abelonogov-ld
added a commit
that referenced
this pull request
Dec 16, 2025
* main: feat: Limit accumulating canvas buffer (#322) chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321) feat: sanitize URLs + semantic conventions for header attributes (#317) refactor: introduce granular ObservabilityOptions (#323) refactor: OY11-846 - Add Session Replay plugin (#313) chore: upgrade react-server-dom-webpack to 19.0.3 (#320) chore: release main (#319) feat: enhance Web Vitals telemetry with semantic attributes (#316) chore: release main (#318) fix: Android - Remove Disk Buffering (#315) chore: readme update with real examples (#314)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the monolithic
Optionsdata class into a more granularObservabilityOptionsstructure. This change introduces nested classes forTracesApi,MetricsApi, andInstrumentations, and replaces boolean flags (disableLogs,disableTraces,disableMetrics,disableErrorTracking).disableLogsis replaced bylogsApiLevel, which allows filtering logs by severity.disableTracesanddisableErrorTrackingare replaced bytracesApito control spans and errors separately.disableMetricsis replaced by themetricsApiobject.instrumentationsproperty.How did you test this change?
Unit tested
Are there any deployment considerations?
No
Note
Introduces ObservabilityOptions with log-level filtering and per-signal/instrumentation toggles, updating SDK, tests, and sample app to the new API.
Optionswith newObservabilityOptionsfeaturingTracesApi,MetricsApi,InstrumentationsandLogLevel.InstrumentationManager/ObservabilityClient/ObservabilityContext/Observabilityto use new options.logsApiLevel; gate spans/errors/metrics viatracesApi/metricsApi; toggle crash reporting, activity lifecycle, and launch time instrumentation viainstrumentations.logsApiLevel,tracesApiincludes (errors/spans),metricsApienabled/disabled, and crash reporting; initialize sampling tests with new options.ObservabilityOptionsine2eapp; adjust default log severity toINFO.Written by Cursor Bugbot for commit d3d187b. This will update automatically on new commits. Configure here.