Skip to content

Conversation

@abelonogov-ld
Copy link
Contributor

@abelonogov-ld abelonogov-ld commented Dec 16, 2025

Summary

Do not produce byte array multiple times and close connection


Note

Avoids repeated byte-array allocations, uses fixed-length streaming with explicit Content-Length, and always disconnects the HTTP connection.

  • Networking (GraphQLClient.kt):
    • Optimize request construction and streaming:
      • Precompute requestBytes (UTF-8) once; use for Content-Length, setFixedLengthStreamingMode, and output stream writes.
      • Remove redundant writes/flushes and avoid multiple toByteArray() calls.
    • Connection handling:
      • Use local connectionLocal with a finally block to disconnect() the HttpURLConnection.
    • Minor cleanup:
      • Remove unused Dispatchers import.
      • Consistent use of connectionLocal for response/error streams.

Written by Cursor Bugbot for commit 298a739. This will update automatically on new commits. Configure here.

@abelonogov-ld abelonogov-ld requested a review from a team as a code owner December 16, 2025 01:42
@abelonogov-ld abelonogov-ld merged commit f199e2d into main Dec 16, 2025
22 checks passed
@abelonogov-ld abelonogov-ld deleted the andrey/graphql-client-optimization branch December 16, 2025 17:37
abelonogov-ld added a commit that referenced this pull request Dec 16, 2025
…bservability-sdk into andrey/fix-masking-offset

* 'andrey/fix-masking-offset' of github.com:launchdarkly/observability-sdk:
  feat: Graphql client memory optimization (#325)
Vadman97 pushed a commit that referenced this pull request Dec 18, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>launchdarkly-observability-android: 0.20.0</summary>

##
[0.20.0](launchdarkly-observability-android-0.19.1...launchdarkly-observability-android-0.20.0)
(2025-12-18)


### Features

* Android SR Identify support
([#330](#330))
([a421812](a421812))
* Graphql client memory optimization
([#325](#325))
([f199e2d](f199e2d))
* Gzip compression for Graphql request body
([#328](#328))
([d862a15](d862a15))
* Limit accumulating canvas buffer
([#322](#322))
([72f2592](72f2592))
</details>

<details><summary>observability: 0.4.11</summary>

##
[0.4.11](observability-0.4.10...observability-0.4.11)
(2025-12-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * highlight.run bumped to 9.25.0
</details>

<details><summary>session-replay: 0.4.11</summary>

##
[0.4.11](session-replay-0.4.10...session-replay-0.4.11)
(2025-12-18)


### Dependencies

* The following workspace dependencies were updated
  * dependencies
    * highlight.run bumped to 9.25.0
</details>

<details><summary>highlight.run: 9.25.0</summary>

##
[9.25.0](highlight.run-9.24.0...highlight.run-9.25.0)
(2025-12-18)


### Features

* sanitize URLs + semantic conventions for header attributes
([#317](#317))
([417b4b8](417b4b8))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Release Android SDK 0.20.0 with multiple performance/features, bump
highlight.run to 9.25.0, and update web packages
(@launchdarkly/observability, @launchdarkly/session-replay) to 0.4.11
consuming the new dependency.
> 
> - **Releases**:
>   - `sdk/@launchdarkly/observability-android` → `0.20.0`
> - Features: Android SR Identify support, GraphQL client memory
optimizations, Gzip GraphQL request bodies, limit accumulating canvas
buffer.
>   - `sdk/highlight-run` → `9.25.0`
> - Features: URL sanitization + semantic conventions for header
attributes.
>   - `sdk/@launchdarkly/observability` → `0.4.11`
>     - Dependency: `highlight.run` bumped to `9.25.0`.
>   - `sdk/@launchdarkly/session-replay` → `0.4.11`
>     - Dependency: `highlight.run` bumped to `9.25.0`.
> - **Version metadata**:
> - Updated versions in `.release-please-manifest.json`,
`package.json`s, and Android `gradle.properties`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
68d9f0b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
abelonogov-ld added a commit that referenced this pull request Jan 13, 2026
* main: (29 commits)
  chore: release main (#344)
  feat: Android double masking with frame drop (#342)
  chore: update LaunchDarkly SDK dependencies (#336)
  chore: Android SR - cleanup privacy settings (#341)
  chore: release main (#340)
  feat: Added privacy options: maskViews, maskXMLViewIds, maskImageViews (#339)
  test: O11Y-908 - Add Android CI workflows (#337)
  chore: release main (#335)
  feat: publish umd for broser environments (#334)
  chore: release main (#333)
  feat: Pause and resume replay capture on app background/foreground (#329)
  fix: Fix compose coordinate offset.  (#331)
  chore: release main (#324)
  fix(highlight.run): correct privacy masking for empty strings (#332)
  feat: Android SR Identify support  (#330)
  feat: Gzip compression for Graphql request body (#328)
  docs: Update readme with options refactor (#326)
  feat: Graphql client memory optimization (#325)
  feat: Limit accumulating canvas buffer (#322)
  chore: Fix existing RRwebGraphQLReplayLogExporterTest tests (#321)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants