feat: Initial version of double masking #327
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| package com.launchdarkly.observability.replay.masking | ||
|
|
||
| import android.graphics.Canvas | ||
| import android.graphics.Color | ||
| import android.graphics.Paint | ||
| import android.graphics.Path | ||
| import android.graphics.Rect | ||
| import kotlin.math.abs | ||
|
|
||
| class MaskApplier { | ||
| private val beforeMaskPaint = Paint().apply { | ||
| color = Color.DKGRAY | ||
| style = Paint.Style.FILL | ||
| } | ||
abelonogov-ld marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| private val afterMaskPaint = Paint().apply { | ||
| color = Color.GRAY | ||
| style = Paint.Style.FILL | ||
| } | ||
|
|
||
| private val maskIntRect = Rect() | ||
| private val path = Path() | ||
|
|
||
| fun drawMasks(canvas: Canvas, beforeMasks: List<Mask>?, afterMasks: List<Mask>?) { | ||
| if (afterMasks == null && beforeMasks == null) return | ||
|
|
||
| beforeMasks?.forEach { mask -> | ||
| drawMask(mask, path, canvas, beforeMaskPaint) | ||
| } | ||
| afterMasks?.forEach { mask -> | ||
| drawMask(mask, path, canvas, afterMaskPaint) | ||
| } | ||
| } | ||
|
|
||
| private fun drawMask(mask: Mask, path: Path, canvas: Canvas, paint: Paint) { | ||
| var isRectangle = true | ||
| if (mask.points != null) { | ||
| val pts = mask.points | ||
| isRectangle = pts[0] == pts[6] && pts[1] == pts[3] && pts[2] == pts[4] && pts[5] == pts[7] | ||
| if (!isRectangle) { | ||
|
|
||
| path.reset() | ||
| path.moveTo(pts[0], pts[1]) | ||
| path.lineTo(pts[2], pts[3]) | ||
| path.lineTo(pts[4], pts[5]) | ||
| path.lineTo(pts[6], pts[7]) | ||
| path.close() | ||
|
|
||
| canvas.drawPath(path, paint) | ||
| } | ||
| } | ||
|
|
||
| if (isRectangle) { | ||
| maskIntRect.left = mask.rect.left.toInt() | ||
| maskIntRect.top = mask.rect.top.toInt() | ||
| maskIntRect.right = mask.rect.right.toInt() | ||
| maskIntRect.bottom = mask.rect.bottom.toInt() | ||
| canvas.drawRect(maskIntRect, paint) | ||
| } | ||
|
There was a problem hiding this comment. Bug: Axis-aligned rectangle masks may use wrong coordinatesWhen |
||
| } | ||
|
|
||
| fun filteredBeforeMasksMap( | ||
| beforeMasksMap: Map<Int, List<Mask>>, | ||
| afterMasksMap: Map<Int, List<Mask>> | ||
| ): Map<Int, List<Mask>>? { | ||
| if (afterMasksMap.count() != beforeMasksMap.count()) { | ||
| return null | ||
| } | ||
|
|
||
| if (afterMasksMap.count() == 0) { | ||
| return null | ||
| } | ||
|
There was a problem hiding this comment. Bug: Empty mask maps cause all captures to failThe Additional Locations (1) |
||
|
|
||
| val result = mutableMapOf<Int, List<Mask>>() | ||
| for ((i, before) in beforeMasksMap) { | ||
| val after = afterMasksMap[i] ?: return null | ||
| val merged = filteredBeforeMasks(before, after) ?: return null | ||
| result[i] = merged | ||
| } | ||
|
|
||
| return result | ||
| } | ||
|
|
||
| // Check if masks are stable and returns null if not | ||
| private fun filteredBeforeMasks( | ||
| beforeMasks: List<Mask>, | ||
| afterMasks: List<Mask> | ||
| ): List<Mask>? { | ||
| if (afterMasks.count() != beforeMasks.count()) { | ||
| return null | ||
| } | ||
|
|
||
| if (afterMasks.count() == 0) { | ||
| return listOf() | ||
| } | ||
|
|
||
| val stabilityTolerance = 40f | ||
| val resultMasks = mutableListOf<Mask>() | ||
| for ((before, after) in beforeMasks.zip(afterMasks)) { | ||
| if (before.viewId != after.viewId) { | ||
| return null | ||
| } | ||
| val diff = abs(after.rect.top - before.rect.top) | ||
| if (diff > stabilityTolerance) { | ||
| return null | ||
| } | ||
| resultMasks += before | ||
| } | ||
|
|
||
| return resultMasks | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.