Skip to content

feat: Gzip compression for Graphql request body #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abelonogov-ld merged 1 commit into from
Dec 16, 2025
Merged

feat: Gzip compression for Graphql request body #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions ...ility-android/lib/src/main/kotlin/com/launchdarkly/observability/network/GraphQLClient.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@ import kotlinx.serialization.json.Json
import kotlinx.serialization.Serializable
import kotlinx.serialization.json.JsonElement
import java.io.IOException
import java.io.ByteArrayOutputStream
import java.net.HttpURLConnection
import java.net.URL
import java.util.zip.GZIPOutputStream

@Serializable
data class GraphQLRequest(
Expand Down Expand Up @@ -71,7 +73,8 @@ class GraphQLClient(
suspend fun <T> execute(
queryFileName: String,
variables: Map<String, JsonElement> = emptyMap(),
dataSerializer: KSerializer<T>
dataSerializer: KSerializer<T>,
compress: Boolean = true
): GraphQLResponse<T> = withContext(DispatcherProviderHolder.current.io) {
var connection: HttpURLConnection? = null
try {
Expand All @@ -83,12 +86,16 @@ class GraphQLClient(

val requestJson = json.encodeToString(request)
val requestBytes = requestJson.toByteArray(Charsets.UTF_8)
val payloadBytes = if (compress) gzip(requestBytes) else requestBytes
val connectionLocal = connectionProvider.openConnection(endpoint).also { connection = it }

connectionLocal.apply {
requestMethod = "POST"
setRequestProperty("Content-Length", requestBytes.size.toString())
setRequestProperty("Content-Length", payloadBytes.size.toString())
setRequestProperty("Content-Type", "application/json")
if (compress) {
setRequestProperty("Content-Encoding", "gzip")
}

// Add custom headers
headers.forEach { (key, value) ->
Expand All @@ -98,12 +105,12 @@ class GraphQLClient(
doOutput = true
connectTimeout = CONNECT_TIMEOUT
readTimeout = READ_TIMEOUT
setFixedLengthStreamingMode(requestBytes.size)
setFixedLengthStreamingMode(payloadBytes.size)
}

// Send request
connectionLocal.outputStream.use { outputStream ->
outputStream.write(requestBytes)
outputStream.write(payloadBytes)
}

// Read response
Expand Down Expand Up @@ -141,4 +148,12 @@ class GraphQLClient(
it.readText()
} ?: throw IllegalStateException("Could not load GraphQL query file: $queryFilepath")
}

private fun gzip(data: ByteArray): ByteArray {
val byteStream = ByteArrayOutputStream()
GZIPOutputStream(byteStream).use { gzipStream ->
gzipStream.write(data)
}
return byteStream.toByteArray()
}
}
Loading