Skip to content

fix(highlight.run): correct privacy masking for empty strings #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vadman97 merged 2 commits into from
Dec 18, 2025
Merged

fix(highlight.run): correct privacy masking for empty strings #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58bf9e2
fix(highlight.run): correct privacy masking for empty strings
Vadman97 Dec 18, 2025
fd30057
Test
SpennyNDaJets Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions e2e/react-router/src/routes/privacy-demo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ export default function PrivacyDemo() {
<p className="ld-mask-text">
<span>Secret text</span>
</p>
<div className="ld-mask-text">
Test a string with shorter words like in and with extra
{' '}spaces.
</div>
</section>

<section>
Expand Down
2 changes: 1 addition & 1 deletion rrweb
Open in desktop
Submodule rrweb updated 7 files
+3 −0 SECURITY.md
+13 −12 packages/rrdom/src/diff.ts
+9 −6 packages/rrweb-snapshot/src/rebuild.ts
+4 −1 packages/rrweb-snapshot/src/utils.ts
+4 −0 packages/rrweb/src/replay/canvas/2d.ts
+98 −0 packages/utils/src/canvas.ts
+4 −0 packages/utils/src/index.ts
Loading