-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Added privacy options: maskViews, maskXMLViewIds, maskImageViews #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...vability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/PrivacyProfile.kt
Outdated
Show resolved
Hide resolved
...vability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/PrivacyProfile.kt
Outdated
Show resolved
Hide resolved
...servability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/MaskViewRef.kt
Show resolved
Hide resolved
agrognetti
approved these changes
Jan 7, 2026
...servability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/MaskViewRef.kt
Outdated
Show resolved
Hide resolved
...vability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/PrivacyProfile.kt
Outdated
Show resolved
Hide resolved
...vability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/PrivacyProfile.kt
Show resolved
Hide resolved
e2e/android/app/src/test/java/com/example/androidobservability/DisablingConfigOptionsE2ETest.kt
Show resolved
Hide resolved
Merged
abelonogov-ld
added a commit
that referenced
this pull request
Jan 7, 2026
* main: feat: Added privacy options: maskViews, maskXMLViewIds, maskImageViews (#339) # Conflicts: # sdk/@launchdarkly/observability-android/README.md # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/PrivacyProfile.kt
Vadman97
pushed a commit
that referenced
this pull request
Jan 7, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>launchdarkly-observability-android: 0.22.0</summary> ## [0.22.0](launchdarkly-observability-android-0.21.0...launchdarkly-observability-android-0.22.0) (2026-01-07) ### Features * Added privacy options: maskViews, maskXMLViewIds, maskImageViews ([#339](#339)) ([1c57dc0](1c57dc0)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Publishes `observability-android` 0.22.0 with new privacy masking options. > > - Updates `sdk/@launchdarkly/observability-android` version to `0.22.0` in `gradle.properties` and `.release-please-manifest.json` > - `CHANGELOG.md`: adds feature entry for `maskViews`, `maskXMLViewIds`, and `maskImageViews` > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7c8b5d9. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added 3 new privacy options:
How did you test this change?
Are there any deployment considerations?
Note
Introduces configurable session replay masking and updates examples/docs.
MaskViewRefandview(...)helpers to reference targetViewclasses byClass,KClass, or FQCNPrivacyProfilewithmaskViews,maskXMLViewIds, andmaskImageViews; implementsviewsMatcher(exact class),xmlViewIdsMatcher(resource entry name normalization), and integrates into matcher listSessionReplayimport path and documents configuring masking viaPrivacyProfileSessionReplaywith newPrivacyProfileoptions; comments out a per-viewldMask()callPrivacyProfileTestcovering defaults, matching behavior, and invalid class handling; marks one e2e traces test@IgnoreWritten by Cursor Bugbot for commit c57d5c2. This will update automatically on new commits. Configure here.