-
Notifications
You must be signed in to change notification settings - Fork 3
chore: Android SR - cleanup privacy settings #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+19
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ef6b1e1)
(cherry picked from commit c57d5c2) # Conflicts: # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/PrivacyProfile.kt
* main: feat: Added privacy options: maskViews, maskXMLViewIds, maskImageViews (#339) # Conflicts: # sdk/@launchdarkly/observability-android/README.md # sdk/@launchdarkly/observability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/PrivacyProfile.kt
...vability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/PrivacyProfile.kt
Show resolved
Hide resolved
agrognetti
approved these changes
Jan 7, 2026
...vability-android/lib/src/main/kotlin/com/launchdarkly/observability/replay/PrivacyProfile.kt
Show resolved
Hide resolved
abelonogov-ld
added a commit
that referenced
this pull request
Jan 8, 2026
* main: chore: Android SR - cleanup privacy settings (#341)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
maskTexttofalsemaskAdditionalMatchers(they might return later under different name and rework to be more universal)How did you test this change?
Are there any deployment considerations?
Note
Streamlines Session Replay masking configuration and docs.
maskSensitivetomaskBySemanticsKeywordsand wires it intoasMatchersList(); defaultfalsePrivacyProfile.maskTextdefault tofalsemaskAdditionalMatchers; drops correspondingaddAll(...)inasMatchersList()viewsMatcher,xmlViewIdsMatcher,textInputMatcher,textMatcher,sensitiveMatcher) tointernalmaskImageViewsremains, moved after listsPrivacyProfileusageWritten by Cursor Bugbot for commit 987e957. This will update automatically on new commits. Configure here.