chore: simplify maui project by removing dependency repetitions#451
Merged
abelonogov-ld merged 13 commits intomainfrom Mar 31, 2026
Merged
chore: simplify maui project by removing dependency repetitions#451abelonogov-ld merged 13 commits intomainfrom
abelonogov-ld merged 13 commits intomainfrom
Conversation
Vadman97
approved these changes
Mar 31, 2026
- Adjusted the exclusion rules for OpenTelemetry JARs in LDObservability.Fat.csproj to ensure the main autoconfigure JAR is excluded while re-including the autoconfigure-spi JAR. - Added a note in build.gradle.kts to clarify the filtering of OpenTelemetry JARs for NuGet packaging.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
abelonogov-ld
added a commit
that referenced
this pull request
Apr 1, 2026
* main: chore: simplify maui project by removing dependency repetitions (#451) fix: Remove 3 dependencies from MAUI Android (3 aar files) (#449) # Conflicts: # sdk/@launchdarkly/mobile-dotnet/android/native/LDObserve/build.gradle.kts # sdk/@launchdarkly/mobile-dotnet/observability/Directory.Build.props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify maui project by removing dependency repetitions. Test on Starbucks app
How did you test this change?
Are there any deployment considerations?
Note
Medium Risk
Medium risk because it changes how native AAR/JAR artifacts are selected, packaged, and auto-wired into consuming Android projects, which could break build/pack behavior if patterns or paths miss/over-include files.
Overview
Bumps the
LaunchDarkly.SessionReplaypackage version to0.5.5and refactors Android native artifact handling to a single shared MSBuild manifest (NativeAndroidDeps.props) used by both local builds (LDObservability.csproj) and the packaging project (LDObservability.Fat.csproj).Simplifies the NuGet
buildTransitivewiring by glob-including packaged*.aar/*.jarand removing the separateLDObservability.android.targets/LDObservability.ios.targetsfiles. The MAUI sample project now enablesEmbedAssembliesIntoApkfor Android.Written by Cursor Bugbot for commit 5e74560. This will update automatically on new commits. Configure here.