-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add tracking support #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7dedb64 to
e4dbc8c
Compare
kinyoklion
requested changes
Apr 10, 2025
src/main/java/com/launchdarkly/openfeature/serverprovider/Provider.java
Outdated
Show resolved
Hide resolved
e4dbc8c to
e198fb8
Compare
tanderson-ld
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs formatting pass.
d59736e to
c4c5455
Compare
kinyoklion
reviewed
Apr 11, 2025
|
|
||
| // This constant is updated automatically by our Gradle script during a release, if the project version has changed | ||
| static final String SDK_VERSION = "0.2.0"; | ||
| static final String SDK_VERSION = "1.0.1"; |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I wonder if there is a gradle problem here. Doesn't need to be sorted in this PR.
kinyoklion
approved these changes
Apr 11, 2025
c4c5455 to
76aefff
Compare
tanderson-ld
approved these changes
Apr 14, 2025
76aefff to
fa69598
Compare
louis-launchdarkly
pushed a commit
that referenced
this pull request
Apr 14, 2025
🤖 I have created a release *beep* *boop* --- ## [1.1.0](1.0.1...1.1.0) (2025-04-14) ### Features * add tracking support ([#36](#36)) ([13ad91f](13ad91f)) * support tracking ([fa69598](fa69598)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
https://launchdarkly.atlassian.net/browse/SDK-1115
https://openfeature.dev/specification/sections/tracking#61-tracking-api
https://github.com/open-feature/java-sdk/blob/main/CHANGELOG.md#1130-2024-12-07
Describe the solution you've provided
From openfeature sdk v1.7.0 till now (v1.14.1), tracking seems to be only change needed from my first glance, so I implement that in the provider.
Related Jira issue: SDK-1115: OpenFeature Tracking Support - Java