Skip to content

chore: Variety of priority fixes #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 22, 2024
Merged

chore: Variety of priority fixes #20

merged 8 commits into from
Nov 22, 2024

Conversation

keelerm84
Copy link
Member

@keelerm84 keelerm84 commented Nov 22, 2024 •
edited
Loading

  • fix!: Rename prompt to messages
  • fix!: Rename LDAIClient.model_config to LDAIClient.config
  • feat: Add support for provider config
  • fix!: Suffix track methods with metrics
  • fix!: Remove max_tokens and temperature as top level model config keys
  • fix!: Change modelId to id

@keelerm84 keelerm84 requested a review from a team as a code owner November 22, 2024 22:01
@keelerm84 keelerm84 force-pushed the mk/sdk-933/priority-fixes branch from 834471d to 19a0535 Compare November 22, 2024 22:17
@keelerm84 keelerm84 force-pushed the mk/sdk-933/priority-fixes branch from 6dcccc0 to b433f2f Compare November 22, 2024 22:34
@keelerm84 keelerm84 merged commit 95015f1 into main Nov 22, 2024
11 checks passed
@keelerm84 keelerm84 deleted the mk/sdk-933/priority-fixes branch November 22, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinyoklion kinyoklion kinyoklion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keelerm84 @kinyoklion