fix: Return AIConfig and LDAITracker separately #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consumers of this SDK are responsible for providing some default value to the `config` method. If that type is of `AIConfig`, customers have the option of providing a tracker instance that will never be useful. To help discourage this, we are making two separate types -- one to represent the default ai config, and one to represent the actual selected config.
keelerm84
changed the title
kinyoklion
approved these changes
Dec 2, 2024
keelerm84
pushed a commit
that referenced
this pull request
Dec 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.4.0](0.3.0...0.4.0) (2024-12-02) ### Features * Return AIConfig and LDAITracker separately [#23](#23) ([96f888f](96f888f)) ### Bug Fixes * Fix context usage for message interpolation ([#24](#24)) ([1159aee](1159aee)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumers of this SDK are responsible for providing some default value
to the
configmethod. If that type is ofAIConfig, customers havethe option of providing a tracker instance that will never be useful.
To address this, we are going to remove the tracker from the
AIConfigtype entirely. Instead, we are going to return the
AIConfigand theLDAITrackerseparately.BEGIN_COMMIT_OVERRIDE
feat: Return AIConfig and LDAITracker separately #23
END_COMMIT_OVERRIDE