Skip to content

fix: add usage tracking to config method #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ldai/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,8 @@ def config(
:param variables: Additional variables for the model configuration.
:return: The value of the model configuration along with a tracker used for gathering metrics.
"""
self._client.track('$ld:ai:config:function:single', context, key, 1)

model, provider, messages, instructions, tracker, enabled = self.__evaluate(key, context, default_value.to_dict(), variables)

config = AIConfig(
Expand Down
25 changes: 25 additions & 0 deletions ldai/testing/test_model_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,3 +303,28 @@ def test_model_initial_config_enabled(ldai_client: LDAIClient):
assert config.model is None
assert config.messages is None
assert config.provider is None


def test_config_method_tracking(ldai_client: LDAIClient):
from unittest.mock import Mock

mock_client = Mock()
mock_client.variation.return_value = {
'_ldMeta': {'enabled': True, 'variationKey': 'test-variation', 'version': 1},
'model': {'name': 'test-model'},
'provider': {'name': 'test-provider'},
'messages': []
}

client = LDAIClient(mock_client)
context = Context.create('user-key')
default_value = AIConfig(enabled=False, model=ModelConfig('fake-model'), messages=[])

config, tracker = client.config('test-config-key', context, default_value)

mock_client.track.assert_called_once_with(
'$ld:ai:config:function:single',
context,
'test-config-key',
1
)
Loading