Skip to content

fix: Pass through proxy user and password if present #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 28, 2025
Merged

fix: Pass through proxy user and password if present #69

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7d68a4c
Add POST/PUT request support and optional parsing features
saada Aug 14, 2025
aaa1442
Add optional SSL verification override
saada Aug 14, 2025
2e72a42
Remove verify_ssl option; can be provided through overrides
keelerm84 Aug 28, 2025
e483b3a
Merge branch 'main' into add-post-support-and-parser-options
keelerm84 Aug 28, 2025
0e4112c
Safely add authorization headers
keelerm84 Aug 28, 2025
8b6b236
Remove previous work with parser option
keelerm84 Aug 28, 2025
aeb47a7
empty? -> nil?
keelerm84 Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/ld-eventsource/client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@ class Client
# The default value for `reconnect_reset_interval` in {#initialize}.
DEFAULT_RECONNECT_RESET_INTERVAL = 60

# The default HTTP method for requests.
DEFAULT_HTTP_METHOD = "GET"

#
# Creates a new SSE client.
#
Expand Down Expand Up @@ -106,7 +109,7 @@ def initialize(uri,
proxy: nil,
logger: nil,
socket_factory: nil,
method: "GET",
method: DEFAULT_HTTP_METHOD,
payload: nil,
retry_enabled: true,
http_client_options: nil)
Expand Down Expand Up @@ -140,6 +143,8 @@ def initialize(uri,
:proxy_address => @proxy.host,
:proxy_port => @proxy.port,
}
base_http_client_options["proxy"][:proxy_username] = @proxy.user unless @proxy.user.nil?
base_http_client_options["proxy"][:proxy_password] = @proxy.password unless @proxy.password.nil?
end

options = http_client_options.is_a?(Hash) ? base_http_client_options.merge(http_client_options) : base_http_client_options
Expand Down