allow flag tracker to be created by calling code

The datasystem doesn't use the flagTracker. Instead of creating and being responsible for something it doesn't use, provide access to the broadcaster so the calling code can create a tracker however it needs.

Author: jsonbailey

lib/ldclient-rb/impl/datasystem.rb

@@ -66,12 +66,15 @@ def data_store_status_provider
       end
 
       #
-      # Returns an interface for tracking changes in feature flag configurations.
+      # Returns the broadcaster for flag change notifications.
       #
-      # @return [LaunchDarkly::Interfaces::FlagTracker]
+      # Consumers can use this broadcaster to build their own flag tracker
+      # or listen for flag changes directly.
       #
-      def flag_tracker
-        raise NotImplementedError, "#{self.class} must implement #flag_tracker"
+      # @return [LaunchDarkly::Impl::Broadcaster]
+      #
+      def flag_change_broadcaster
+        raise NotImplementedError, "#{self.class} must implement #flag_change_broadcaster"
       end
 
       #
@@ -101,21 +104,6 @@ def store
         raise NotImplementedError, "#{self.class} must implement #store"
       end
 
-      #
-      # Injects the flag value evaluation function used by the flag tracker to
-      # compute FlagValueChange events. The function signature should be
-      # (key, context) -> value.
-      #
-      # This method must be called after initialization to enable the flag tracker
-      # to compute value changes for flag change listeners.
-      #
-      # @param eval_fn [Proc] The evaluation function
-      # @return [void]
-      #
-      def set_flag_value_eval_fn(eval_fn)
-        raise NotImplementedError, "#{self.class} must implement #set_flag_value_eval_fn"
-      end
-
       #
       # Sets the diagnostic accumulator for streaming initialization metrics.
       # This should be called before start() to ensure metrics are collected.

lib/ldclient-rb/impl/datasystem/fdv1.rb

@@ -3,7 +3,6 @@
 require 'ldclient-rb/impl/data_source'
 require 'ldclient-rb/impl/data_store'
 require 'ldclient-rb/impl/datasource/null_processor'
-require 'ldclient-rb/impl/flag_tracker'
 require 'ldclient-rb/impl/broadcaster'
 
 module LaunchDarkly
@@ -51,10 +50,6 @@ def initialize(sdk_key, config)
           # Set up data source plumbing
           @data_source_broadcaster = LaunchDarkly::Impl::Broadcaster.new(@shared_executor, @config.logger)
           @flag_change_broadcaster = LaunchDarkly::Impl::Broadcaster.new(@shared_executor, @config.logger)
-          @flag_tracker_impl = LaunchDarkly::Impl::FlagTracker.new(
-            @flag_change_broadcaster,
-            lambda { |_key, _context| nil } # Replaced by client to use its evaluation method
-          )
           @data_source_update_sink = LaunchDarkly::Impl::DataSource::UpdateSink.new(
             @store_wrapper,
             @data_source_broadcaster,
@@ -105,18 +100,6 @@ def store
           @store_wrapper
         end
 
-        #
-        # Injects the flag value evaluation function used by the flag tracker to
-        # compute FlagValueChange events. The function signature should be
-        # (key, context) -> value.
-        #
-        # @param eval_fn [Proc] The evaluation function
-        # @return [void]
-        #
-        def set_flag_value_eval_fn(eval_fn)
-          @flag_tracker_impl = LaunchDarkly::Impl::FlagTracker.new(@flag_change_broadcaster, eval_fn)
-        end
-
         #
         # Sets the diagnostic accumulator for streaming initialization metrics.
         # This should be called before start() to ensure metrics are collected.
@@ -147,12 +130,12 @@ def data_store_status_provider
         end
 
         #
-        # Returns the flag tracker.
+        # Returns the broadcaster for flag change notifications.
         #
-        # @return [LaunchDarkly::Interfaces::FlagTracker]
+        # @return [LaunchDarkly::Impl::Broadcaster]
         #
-        def flag_tracker
-          @flag_tracker_impl
+        def flag_change_broadcaster
+          @flag_change_broadcaster
         end
 
         #

spec/impl/datasystem/fdv1_spec.rb

@@ -11,22 +11,6 @@ module DataSystem
         subject { FDv1.new(sdk_key, config) }
 
         describe "#initialize" do
-          it "creates data store status provider" do
-            expect(subject.data_store_status_provider).to be_a(LaunchDarkly::Impl::DataStore::StatusProvider)
-          end
-
-          it "creates data source status provider" do
-            expect(subject.data_source_status_provider).to be_a(LaunchDarkly::Impl::DataSource::StatusProvider)
-          end
-
-          it "creates flag tracker" do
-            expect(subject.flag_tracker).to be_a(LaunchDarkly::Impl::FlagTracker)
-          end
-
-          it "creates store wrapper" do
-            expect(subject.store).to be_a(LaunchDarkly::Impl::FeatureStoreClientWrapper)
-          end
-
           it "injects data_source_update_sink into config" do
             subject  # Force creation of FDv1 instance
             expect(config.data_source_update_sink).to be_a(LaunchDarkly::Impl::DataSource::UpdateSink)
@@ -139,20 +123,6 @@ module DataSystem
           end
         end
 
-        describe "#set_flag_value_eval_fn" do
-          it "updates the flag tracker with the evaluation function" do
-            eval_fn = ->(key, context) { "value" }
-            original_tracker = subject.flag_tracker
-
-            subject.set_flag_value_eval_fn(eval_fn)
-
-            # Should have created a new flag tracker with the eval function
-            expect(subject.flag_tracker).to be_a(LaunchDarkly::Impl::FlagTracker)
-            # The tracker should be different (new instance with eval_fn)
-            expect(subject.flag_tracker.object_id).not_to eq(original_tracker.object_id)
-          end
-        end
-
         describe "#set_diagnostic_accumulator" do
           it "stores the diagnostic accumulator" do
             diagnostic_accumulator = double("DiagnosticAccumulator")
@@ -172,9 +142,9 @@ module DataSystem
           end
         end
 
-        describe "#flag_tracker" do
-          it "returns the flag tracker" do
-            expect(subject.flag_tracker).to be_a(LaunchDarkly::Impl::FlagTracker)
+        describe "#flag_change_broadcaster" do
+          it "returns the flag change broadcaster" do
+            expect(subject.flag_change_broadcaster).to be_a(LaunchDarkly::Impl::Broadcaster)
           end
         end
 

spec/impl/datasystem_spec.rb

@@ -28,8 +28,8 @@ module Impl
           expect { test_instance.data_store_status_provider }.to raise_error(NotImplementedError, /must implement #data_store_status_provider/)
         end
 
-        it "flag_tracker raises NotImplementedError" do
-          expect { test_instance.flag_tracker }.to raise_error(NotImplementedError, /must implement #flag_tracker/)
+        it "flag_change_broadcaster raises NotImplementedError" do
+          expect { test_instance.flag_change_broadcaster }.to raise_error(NotImplementedError, /must implement #flag_change_broadcaster/)
         end
 
         it "data_availability raises NotImplementedError" do
@@ -44,10 +44,6 @@ module Impl
           expect { test_instance.store }.to raise_error(NotImplementedError, /must implement #store/)
         end
 
-        it "set_flag_value_eval_fn raises NotImplementedError" do
-          expect { test_instance.set_flag_value_eval_fn(nil) }.to raise_error(NotImplementedError, /must implement #set_flag_value_eval_fn/)
-        end
-
         it "set_diagnostic_accumulator raises NotImplementedError" do
           accumulator = double("DiagnosticAccumulator")
           expect { test_instance.set_diagnostic_accumulator(accumulator) }.to raise_error(NotImplementedError, /must implement #set_diagnostic_accumulator/)