feat: Expose NullDataSourceBuilder from crate root #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w4
changed the title
This may seem a bit strange at first, but it's extremely useful when a persistent `DataStore` is filled externally to the LaunchDarkly SDK. In our particular use case, we implement a `PersistentDataStore` using an internal blend of Kafka and RocksDB to allow us to isolate the outbound calls towards LD to a single service. An alternative to this is allowing `offline` mode to continue reading from the `DataStore`, but this is a breaking change.
Member
|
Thank you for your contribution.
Not at all! We actually have a feature for this, called Daemon Mode. The rust SDK doesn't yet have support for it, but it would remove the need to expose this builder, along with the forced initialization method you have added. I can try to add support for that this week if that's okay with you. |
Member
Author
|
Closing in favour of #110, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may seem a bit strange at first, but it's extremely useful when a persistent
DataStoreis filled externally to the LaunchDarkly SDK.In our particular use case, we implement a
PersistentDataStoreusing an internal blend of Kafka and RocksDB to allow us to isolate the outbound calls towards LD to a single service.An alternative to this is allowing
offlinemode to continue reading from theDataStore, but this is a breaking change.Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.