Merged
Conversation
Squashed commits: [2231514] Turn off snapshotting is queue is full [dc5f244] chore: add logging into session replay
mario-launchdarkly
approved these changes
Oct 28, 2025
| send(EventQueueItem(payload: payload)) | ||
| } | ||
|
|
||
| func send(_ item: EventQueueItem) { |
There was a problem hiding this comment.
Bug: Dequeue Cost Mismatch
In the dequeue method, when the limit or cost threshold is reached, only the cost of the last item is subtracted from currentSize, but i+1 items (all accumulated items) are removed from storage. This causes currentSize to become incorrect. The line currentSize -= item.cost should subtract the sum of costs of all i+1 items being removed, not just the last one.
abelonogov-ld
pushed a commit
that referenced
this pull request
Oct 28, 2025
🤖 I have created a release *beep* *boop* --- ## [0.7.0](0.6.0...0.7.0) (2025-10-28) ### Features * Session Replay improvements ([#53](#53)) ([45c4cbc](45c4cbc)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps version to 0.7.0 and updates changelog with Session Replay improvements. > > - **Versioning**: > - Update `.release-please-manifest.json` to `0.7.0`. > - **Changelog**: > - Add `0.7.0` section noting Session Replay improvements. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit e9a0935. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Adds buffer-aware screenshot capture with player wake-up events and optional SR stats, refactors event queue API and batch worker (logging + adaptive pacing), and enhances HTTP error descriptions.
generateWakeUpEvents), applies consistent padding to interactions, and rebuilds full snapshot sizing viapaddedWidth/Height.dataHashValue; properties now immutable.SnapshotTakerchecksEventQueue.isFull()before capturing; useseventQueue.send(_ payload)and@MainActorcapture.SessionReplayStatsfor periodic image/FPS logging (debug-only path).send(_ payload: EventQueueItemPayload); addsisFull(); internal fields privatized.OSLog, logs export errors viaos_log, and uses adaptive sleep with a minimum interval.EventQueue.sendacross log/memory/lifecycle/user-interaction producers;BatchWorkernow initialized withoptions.log.NetworkError.httpStatusdescription now includes optional response body data.Written by Cursor Bugbot for commit 4d83e20. This will update automatically on new commits. Configure here.