fix: resolve failing tests and gofmtcheck script#390
Open
Rayhan1967 wants to merge 1 commit intolaunchdarkly:mainfrom
Open
fix: resolve failing tests and gofmtcheck script#390Rayhan1967 wants to merge 1 commit intolaunchdarkly:mainfrom
Rayhan1967 wants to merge 1 commit intolaunchdarkly:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two maintenance issues identified in the repository:
gofmtcheck.shLogic: The formatting check script contained a variable reference error, checking${gofmt_files}instead of the correct${gofmts_files}. This allowed formatting checks to erroneously pass even whengofmtsissues were present. This PR updates the reference to ensure accurate format validation.TestValidateRuleResourceDataunit test inlaunchdarkly/rule_helper_test.gowas failing due to outdated assertions. A previous fix (REL-10234) introduced an intentional exception allowingcontext_kind: "user"to be used alongsidevariation. This PR updates the test cases to accurately reflect this schema validation change.Changes
scripts/gofmtcheck.sh: Corrected variable reference.launchdarkly/rule_helper_test.go: Refactored test cases for context kind validation.