Feat/pretty adv #155
Closed
Feat/pretty adv #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cases - Enhanced CaseExpr formatting with proper WHEN/THEN/ELSE alignment - Improved WindowDef formatting for OVER clauses with PARTITION BY/ORDER BY - Enhanced JoinExpr formatting for complex JOIN ON conditions with proper indentation - Added containsMultilineStringLiteral helper to preserve string literal content - Created comprehensive test suite for misc SQL scenarios including CTEs, window functions, LATERAL joins, and complex subqueries - Fixed critical CaseExpr bug that caused 'CASE1' syntax error by ensuring proper spacing - Generated snapshots for 6 misc test cases to visualize pretty formatting improvements - All kitchen-sink tests now pass with AST equivalence validation Co-Authored-By: Dan Lynch <[email protected]>
- Added tests with pretty=false for all 6 misc SQL cases to ensure no formatting is applied when pretty is disabled - Generated 12 new snapshots (6 pretty=true, 6 pretty=false) to validate correct scoping behavior - Verified that pretty=false produces single-line SQL output while pretty=true produces formatted SQL - All pretty formatting logic in deparser.ts is properly guarded with this.formatter.isPretty() checks - Ensures formatting is only applied when pretty=true, addressing scoping concerns Co-Authored-By: Dan Lynch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.