fix: update PG13-to-PG14 transformer to use runtime schemas

[devin-ai-integration]

Fix PG13-to-PG14 Transformer Using Runtime Schemas

This PR updates the PG13-to-PG14 transformer to use runtime schemas for understanding wrapped/inline properties and fixes multiple transformation issues to significantly improve test pass rates.

Link to Devin run

https://app.devin.ai/sessions/8a032672a9424faba2e0cd048f2d23e9

Requested by

Dan Lynch ([email protected])

Key Changes

1. Fixed A_Const Transformation Direction

• Issue: The transformer was doing PG14→PG13 transformation instead of PG13→PG14
• Fix: Corrected the transformation to convert from PG13 format (separate ival, fval, sval fields) to PG14 format (single val field with typed wrappers)
• Impact: Resolves core constant value transformation failures

2. Added FuncCall funcformat Handling

• Issue: FuncCall nodes were missing required funcformat field in PG14
• Fix: Added FuncCall method that ensures funcformat defaults to "COERCE_EXPLICIT_CALL" when not present
• Impact: Fixes function call transformation failures

3. Fixed SelectStmt sortClause Processing

• Issue: SelectStmt was handling orderClause but missing sortClause transformation
• Fix: Added sortClause handling to ensure nested FuncCall nodes are properly transformed
• Impact: Resolves geometry test failures where FuncCall nodes in sortClause weren't getting funcformat

4. Added TypeCast Method

• Issue: TypeName nodes within TypeCast weren't being properly transformed
• Fix: Added TypeCast method to ensure recursive TypeName transformation
• Impact: Fixes TypeName field defaults in nested structures

5. Added ColumnDef and Constraint Methods

• Issue: Missing field transformations in table definition structures
• Fix: Added methods to handle ColumnDef typeName transformation and Constraint pktable.inh defaults
• Impact: Resolves CREATE TABLE related test failures

6. Runtime Schema Integration

• Added: Imports for pg13RuntimeSchema and pg14RuntimeSchema
• Added: Helper methods for field type checking (isFieldWrapped, getFieldType)
• Prepared: Infrastructure for more sophisticated runtime schema-based transformations

Test Results

Before: Many tests failing due to fundamental transformation issues
After: 98/258 tests passing (significant improvement)

Specific Test Improvements

• ✅ original-upstream-geometry - Fixed with sortClause handling
• ✅ original-upstream-misc_functions - Fixed with TypeCast method
• ✅ Multiple CREATE TABLE tests - Fixed with ColumnDef/Constraint methods

Testing Transparency

What I Actually Checked

• ✅ Ran full PG13-PG14 test suite multiple times during development
• ✅ Verified specific failing tests now pass (geometry, misc_functions)
• ✅ Confirmed no regressions in previously passing tests
• ✅ Tested individual transformation methods with debugging output
• ✅ Verified A_Const transformation handles all value types (Integer, Float, String, BitString, Boolean)

What I Did Not Check

• ❌ Other version transformations (PG14-PG15, etc.) - focused on PG13-PG14 as requested
• ❌ Performance impact of the changes
• ❌ Edge cases beyond what the test suite covers
• ❌ Complete funcformat logic - some tests still expect "COERCE_SQL_SYNTAX" vs "COERCE_EXPLICIT_CALL"

Remaining Work

While this PR significantly improves the PG13-PG14 transformer, there are still 160/258 tests failing. The remaining issues appear to be:

1. funcformat Context Sensitivity: Some FuncCall nodes should use "COERCE_SQL_SYNTAX" instead of "COERCE_EXPLICIT_CALL" - needs investigation of when to use which value
2. Additional Field Defaults: Some node types may need more sophisticated default value handling
3. Complex Nested Transformations: Some deeply nested structures may need additional transformation methods

Review Checklist

• Verify the A_Const transformation correctly handles all constant types
• Test that FuncCall funcformat is added to nested function calls
• Confirm SelectStmt properly processes both orderClause and sortClause
• Check that TypeName transformations work within TypeCast contexts
• Validate ColumnDef and Constraint transformations for CREATE TABLE statements

The transformer now uses runtime schema imports and has the foundation for more sophisticated schema-based transformations as the remaining issues are addressed.

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring