PG13->PG14 AST and Beginning of PG14-15 🚀

[pyramation]

fix: improve PG13->PG14 AST conversion with enhanced function handling

Summary

This PR enhances the PostgreSQL AST transformation from version 13 to 14, focusing on function parameter modes, enum mappings, and pg_catalog prefix handling. The changes improve test coverage from an initial failing state to 228/258 passing tests (30 still failing).

Key improvements:

• Enhanced variadic parameter detection for polymorphic types (any, anyarray)
• Added logic to preserve existing FUNC_PARAM_VARIADIC modes instead of incorrectly overriding them
• Implemented pg_catalog prefix addition for SQL standard functions (btrim, trim, ltrim, rtrim, etc.)
• Refined context-aware transformation logic for function calls and parameter handling

Remaining challenges: 30 tests still fail across various categories including function prefixes, enum mappings, and parameter mode transformations.

Review & Testing Checklist for Human

• Verify no regressions: Run the full test suite to confirm 228+ tests still pass and no previously passing tests were broken
• Test variadic parameter logic: Check that functions with VARIADIC parameters (especially polymorphic ones) preserve their parameter modes correctly
• Validate pg_catalog prefix behavior: Ensure the new prefix logic only affects intended SQL standard functions and doesn't break existing function calls
• Review remaining failures: Examine some of the 30 still-failing tests to validate that the overall approach is sound
• Spot-check enum mappings: Verify that TableLikeOption and FunctionParameterMode transformations align with PG13->PG14 changes

Recommended test plan: Run yarn test __tests__/kitchen-sink/13-14 and sample a few failing tests from different categories (polymorphism, aggregates, create_index) to ensure the transformation logic is working as expected.

---

Diagram

%%{ init : { "theme" : "default" }}%%
graph TB
    subgraph "Transform Package"
        V13TO14["packages/transform/src/transformers/v13-to-v14.ts"]:::major-edit
        UTILS["packages/transform/test-utils/index.ts"]:::context
    end
    
    subgraph "Test Categories"
        POLY["polymorphism tests"]:::context
        AGG["aggregates tests"]:::context
        STRINGS["strings tests"]:::context
        FUNCS["function tests"]:::context
    end
    
    subgraph "Key Methods Modified"
        FUNCCALL["FuncCall()"]:::major-edit
        FUNCPARAM["FunctionParameter()"]:::major-edit
        GETFUNC["getFuncformatValue()"]:::minor-edit
    end
    
    V13TO14 --> FUNCCALL
    V13TO14 --> FUNCPARAM
    V13TO14 --> GETFUNC
    
    
    FUNCCALL --> POLY
    FUNCPARAM --> AGG
    GETFUNC --> STRINGS
    
    subgraph Legend
        L1["Major Edit"]:::major-edit
        L2["Minor Edit"]:::minor-edit
        L3["Context/No Edit"]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF

Loading

Notes

• Session context: This work was requested by Dan Lynch (@pyramation) to complete PG13->PG14 AST conversion
• Link to Devin run: https://app.devin.ai/sessions/685b5e38600849cea91d4514504090ad
• Architecture improvement: The transformation logic is now more context-aware and handles edge cases better, though 30 test failures remain to be addressed
• Risk areas: The variadic parameter detection and pg_catalog prefix logic involve complex conditional logic that may have unintended side effects on edge cases not covered by the current test suite

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring