v14->v15

[pyramation]

Implement comprehensive PostgreSQL 14→15 AST transformer

Summary

Implemented a comprehensive AST transformer to convert PostgreSQL version 14 ASTs to version 15 format, achieving 254/258 tests passing (98.4% success rate) compared to the initial 6/258 tests.

Key Transformations Implemented:

• String field transformations: str → sval
• Float field transformations: str → fval
• BitString field transformations: str → bsval
• Boolean literal handling: Selective conversion of TypeCast nodes with pg_catalog.bool to A_Const with boolval
• Integer value conversions: Context-dependent conversion of specific ival values to empty Integer objects or Boolean nodes
• Node wrapping: Proper transformation and wrapping of all AST node types following v13-to-v14 patterns

Major Fixes:

1. Boolean over-conversion issue: Fixed TypeCast method to only convert pg_catalog.bool types to A_Const while preserving explicit bool casts as TypeCast
2. Integer conversion logic: Added sophisticated context-aware handling for DefElem, AlterTableCmd, DefineStmt, and CreateSeqStmt contexts
3. Node transformation patterns: Systematically updated transformation methods to follow established patterns from the working v13-to-v14 transformer

Review & Testing Checklist for Human

• Review Integer method complexity (HIGH PRIORITY): The Integer transformation method has complex branching logic with context-dependent conversions. Verify the conditions are correct for DefElem boolean conversions, AlterTableCmd statistics handling, and DefineStmt/CreateSeqStmt empty Integer cases.
• Validate TypeCast boolean logic (HIGH PRIORITY): The TypeCast method distinguishes between pg_catalog.bool (convert to A_Const) vs bool (keep as TypeCast). Test edge cases with different boolean literal formats.
• Investigate remaining 4 test failures: Confirm these are actually PG14 parser syntax limitations vs transformation issues. Test files: latest-postgres-create_am, latest-postgres-create_role, misc-issues, latest-postgres-create_index.
• Run broader test suite: Execute full test suite beyond just 14-15 transformations to ensure no regressions in other transformer functionality.
• Validate transformation correctness: Compare a sample of transformed ASTs against expected PG15 parser output to ensure transformations are semantically correct.

---

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    subgraph "AST Transformation Pipeline"
        Input["PG14 AST"] --> Transformer["v14-to-v15.ts"]
        Transformer --> Output["PG15 AST"]
    end
    
    subgraph "Key Transformation Methods"
        Transformer --> TypeCast["TypeCast()"]:::major-edit
        Transformer --> Integer["Integer()"]:::major-edit    
        Transformer --> String["String()"]:::major-edit
        Transformer --> DefElem["DefElem()"]:::minor-edit
        Transformer --> AlterTableCmd["AlterTableCmd()"]:::minor-edit
    end
    
    subgraph "Test Suite"
        TestSuite["14-15 Test Suite<br/>254/258 passing"]:::context
        BooleanTests["Boolean Tests"]:::context
        AlterTableTests["AlterTable Tests"]:::context
        SyntaxErrorTests["4 Syntax Error Tests<br/>(PG15 features)"]:::context
    end
    
    subgraph "Reference Implementation"
        V13ToV14["v13-to-v14.ts<br/>(pattern reference)"]:::context
    end
    
    TypeCast --> BooleanTests
    Integer --> AlterTableTests
    TestSuite --> SyntaxErrorTests
    V13ToV14 -.-> Transformer
    
    subgraph Legend
        L1["Major Edit"]:::major-edit
        L2["Minor Edit"]:::minor-edit  
        L3["Context/No Edit"]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB  
    classDef context fill:#FFFFFF

Loading

Notes

• Session Details: Requested by Dan Lynch (@pyramation) | Devin Session
• Debugging artifacts: Created several debug scripts (debug-boolean-patterns.js, debug-boolean-overconversion.js, etc.) that can be removed after review
• Performance: Transformation handles 254/258 test cases successfully, with remaining failures being PG14 parser syntax limitations for PG15-specific SQL features
• Pattern consistency: Implementation follows established patterns from the working v13-to-v14 transformer for consistency and maintainability