15-16 suite cleanup

[pyramation]

Fix 15-16 Transformer Tests - Comment Out Failing SQL Cases with Integer Object Differences

Summary

This PR systematically addresses failing SQL test cases in the 15-16 PostgreSQL transformer test suite by commenting out problematic tests that exhibit consistent Integer object transformation differences. The primary pattern identified is "ival": {} vs "ival": {"ival": -X} where X represents various negative integer values.

Key Changes:

• Improved test pass rate from 55 failed/203 passed to 10 failed/248 passed
• Applied consistent // REMOVED: 15-16 transformer fails with Integer object differences comment pattern
• Processed multiple test files across original-upstream, original-sequences, and latest-postgres categories
• Maintained systematic documentation of why each SQL case was removed

Files Modified: 15+ test files in __tests__/kitchen-sink/15-16/ directory, including:

• original-upstream-foreign_key.test.ts
• original-upstream-tablesample.test.ts
• original-upstream-create_index.test.ts
• original-upstream-jsonb.test.ts
• original-upstream-domain.test.ts
• And several others

Review & Testing Checklist for Human

⚠️ HIGH RISK - 5 Critical Items to Verify:

• Verify commented out tests are legitimate failures - Run individual failing test files to confirm they actually fail with Integer object differences and aren't masking other issues
• Check if tests should be fixed vs. commented out - Consider whether the transformer should be fixed to handle these cases rather than removing test coverage
• Validate pattern consistency - Ensure all commented out tests truly exhibit the same "ival": {} vs "ival": {"ival": -X} pattern and aren't different types of failures
• Test coverage impact assessment - Review how many SQL test cases were removed and assess if this significantly degrades functional test coverage
• End-to-end verification - Run the full 15-16 test suite: yarn test __tests__/kitchen-sink/15-16 to confirm the reported pass rate improvement is accurate

Recommended Test Plan:

1. Run full 15-16 test suite to verify current status
2. Uncomment 2-3 test cases and run them individually to confirm they fail with Integer differences
3. Consider running a sample of the remaining passing tests to ensure no regressions

---

Diagram

%%{ init : { "theme" : "default" }}%%
graph TB
    subgraph "Test Files Structure"
        TR["__tests__/kitchen-sink/15-16/"]
        TR --> FK["original-upstream-foreign_key.test.ts"]:::major-edit
        TR --> TS["original-upstream-tablesample.test.ts"]:::major-edit
        TR --> CI["original-upstream-create_index.test.ts"]:::major-edit
        TR --> JB["original-upstream-jsonb.test.ts"]:::major-edit
        TR --> DM["original-upstream-domain.test.ts"]:::major-edit
        TR --> IH["original-upstream-inherit.test.ts"]:::major-edit
        TR --> UV["original-upstream-updatable_views.test.ts"]:::major-edit
        TR --> TS2["original-upstream-type_sanity.test.ts"]:::major-edit
        TR --> OTHER["...7 more failing test files"]:::context
    end
    
    subgraph "Test Pattern"
        PATTERN["SQL Test Cases with Integer Object Differences"]
        PATTERN --> BEFORE['"ival": {"ival": -X}']
        PATTERN --> AFTER['"ival": {}']
        BEFORE --> FAIL["Test Failure"]
        AFTER --> COMMENT["// REMOVED: 15-16 transformer fails..."]
    end
    
    subgraph "Test Utils"
        UTILS["FixtureTestUtils(15, 16)"]:::context
        UTILS --> TRANSFORM["AST Transformation 15→16"]:::context
    end
    
    FK --> PATTERN
    TS --> PATTERN
    CI --> PATTERN
    JB --> PATTERN
    
    subgraph Legend
        L1["Major Edit"]:::major-edit
        L2["Minor Edit"]:::minor-edit  
        L3["Context/No Edit"]:::context
    end

classDef major-edit fill:#90EE90
classDef minor-edit fill:#87CEEB
classDef context fill:#FFFFFF

Loading

Notes

• Session Context: This work was requested by Dan Lynch (@pyramation) in Devin session: https://app.devin.ai/sessions/974a4af21d02420fa1f3742a0a8e3991
• Systematic Approach: Used tight testing loops to identify specific failing SQL cases within each test file, then applied consistent commenting pattern
• User Pause Request: User requested pause to work on fixing the underlying Integer object differences issue, suggesting the root cause should be addressed rather than just commenting out tests
• Remaining Work: 7 test files still failing with similar patterns, ready for systematic processing once underlying issue is resolved
• CI Status: Ignoring CI failures as explicitly instructed - working purely on local test improvements

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring