Skip to content

Mobile: Fixes #15120: RTE heading links scroll to bottom instead of top in Editing mode #15128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varunkumar-22 wants to merge 3 commits into
base: dev
Choose a base branch
from
+10 −0
Open

Mobile: Fixes #15120: RTE heading links scroll to bottom instead of top in Editing mode #15128

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3c2818
Mobile: Fixes #15120: Fix RTE heading links scrolling heading to bott…
varunkumar-22 Apr 16, 2026
1e9f826
Mobile: Guard scrollIntoView call for jsdom test environment
varunkumar-22 Apr 16, 2026
e3392d9
Mobile: Use window.scrollTo instead of scrollIntoView options for bro…
varunkumar-22 Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/editor/ProseMirror/utils/jumpToHash.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ const jumpToHash = (targetHash: string): Command => (state, dispatch, view) => {
}

let targetHeaderPos: number|null = null;
let targetHeadingNodePos: number|null = null;
forEachHeading(view.state.doc, (node, hash, pos) => {
if (hash === targetHash) {
// Subtract one to move the selection to the end of
// the node:
targetHeaderPos = pos + node.nodeSize - 1;
targetHeadingNodePos = pos;
}

return targetHeaderPos !== null;
Expand All @@ -26,6 +28,14 @@ const jumpToHash = (targetHash: string): Command => (state, dispatch, view) => {
.scrollIntoView(),
);
if (view) {
// Scroll the heading to the top of the viewport, consistent with view
// mode behavior. Uses window.scrollTo to avoid relying on scrollIntoView
// option support across WebView versions.
const headingDom = view.nodeDOM(targetHeadingNodePos);
if (headingDom instanceof Element) {
const rect = headingDom.getBoundingClientRect();
window.scrollTo(0, window.scrollY + rect.top);
}
focus('jumpToHash', view);
}
}
Expand Down
Loading