Desktop: Fixes #15194: Fix positioning of nested ink containers#15196
Open
personalizedrefrigerator wants to merge 4 commits intolaurent22:devfrom
Conversation
The bbox changes to ink.rs caused incorrect positioning in the "Linguistics Basics" test note.
coderabbitai
Bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nested ink containers were positioned incorrectly when imported into Joplin.
See #15194.
Solution
Import ink within outline elements as embedded ink.
Testing
With this change, the 1s and 0s in #15194 that were previously mispositioned are now imported correctly:
This also fixes an ink positioning issue mentioned in #15178 (from the test notebook provided in comment):