Skip to content

Desktop: Importing from OneNote: Convert an ink-related import error to a warning #15197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
personalizedrefrigerator wants to merge 2 commits into
base: dev
Choose a base branch
from
+8 −4
Open

Desktop: Importing from OneNote: Convert an ink-related import error to a warning #15197

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dc7412
Desktop: Importing from OneNote: Allow ink to have no associated strokes
personalizedrefrigerator Apr 25, 2026
09f394a
Add comment
personalizedrefrigerator Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/onenote-converter/parser/src/one/property_set/ink_data_node.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ use crate::one::property::{PropertyType, simple};
use crate::one::property_set::PropertySetId;
use crate::onestore::object::Object;
use crate::shared::exguid::ExGuid;
use parser_utils::errors::{ErrorKind, Result};
use parser_utils::errors::Result;
use parser_utils::log_warn;

/// An ink data container.
pub(crate) struct Data {
Expand All @@ -17,9 +18,12 @@ pub(crate) fn parse(object: &Object) -> Result<Data> {
}

let strokes =
ObjectReference::parse_vec(PropertyType::InkStrokes, object)?.ok_or_else(|| {
ErrorKind::MalformedOneNoteFileData("ink data node has no strokes".into())
})?;
ObjectReference::parse_vec(PropertyType::InkStrokes, object)?.unwrap_or_else(|| {
// It seems to be possible for an InkDataNode to have no associated InkStrokes object.
// See https://discourse.joplinapp.org/t/error-importing-notes-from-onenote/49671
log_warn!("ink data node {:?} has no strokes", object.id());
vec![]
});
let bounding_box = simple::parse_vec_i32(PropertyType::InkBoundingBox, object)?
.filter(|values| values.len() == 4)
.map(|values| [values[0], values[1], values[2], values[3]]);
Expand Down
Loading