Show all client errors when tracks fail to load or play

common/src/main/java/dev/lavalink/youtube/AllClientsFailedException.java

@@ -0,0 +1,18 @@
+package dev.lavalink.youtube;
+
+import com.sedmelluq.discord.lavaplayer.tools.FriendlyException;
+
+import java.util.List;
+
+/**
+ * Thrown when all clients failed to load a track.
+ */
+public class AllClientsFailedException extends FriendlyException {
+    /**
+     * @param suppressed The exceptions that were caused client failures.
+     */
+    public AllClientsFailedException(List<Throwable> suppressed) {
+        super("All clients failed to load the item. See suppressed exceptions for details.", Severity.SUSPICIOUS, null);
+        suppressed.forEach(this::addSuppressed);
+    }
+}

common/src/main/java/dev/lavalink/youtube/ClientException.java

@@ -0,0 +1,14 @@
+package dev.lavalink.youtube;
+
+import dev.lavalink.youtube.clients.skeleton.Client;
+import org.jetbrains.annotations.NotNull;
+
+/**
+ * Wraps an exception with client context
+ */
+public class ClientException extends Exception {
+    public ClientException(@NotNull String message, @NotNull Client client, @NotNull Throwable cause) {
+        super(String.format("Client [%s] failed: %s", client.getIdentifier(), message), cause);
+        addSuppressed(ClientInformation.create(client));
+    }
+}

common/src/main/java/dev/lavalink/youtube/YoutubeAudioSourceManager.java

@@ -34,6 +34,7 @@
 import java.io.DataOutput;
 import java.io.IOException;
 import java.net.URI;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 import java.util.regex.Matcher;
@@ -213,7 +214,8 @@ public AudioItem loadItem(@NotNull AudioPlayerManager manager, @NotNull AudioRef
 
     @Nullable
     protected AudioItem loadItemOnce(@NotNull AudioReference reference) {
-        Throwable lastException = null;
+        AudioItem item = null;
+        List<Throwable> exceptions = new ArrayList<>();
 
         try (HttpInterface httpInterface = httpInterfaceManager.getInterface()) {
             Router router = getRouter(httpInterface, reference.identifier);
@@ -243,28 +245,27 @@ protected AudioItem loadItemOnce(@NotNull AudioReference reference) {
                 httpInterface.getContext().setAttribute(Client.OAUTH_CLIENT_ATTRIBUTE, client.supportsOAuth());
 
                 try {
-                    AudioItem item = router.route(client);
-
-                    if (item != null) {
-                        return item;
-                    }
+                    item = router.route(client);
                 } catch (CannotBeLoaded cbl) {
                     throw ExceptionTools.wrapUnfriendlyExceptions("This video cannot be loaded.", Severity.SUSPICIOUS, cbl.getCause());
                 } catch (Throwable t) {
                     log.debug("Client \"{}\" threw a non-fatal exception, storing and proceeding...", client.getIdentifier(), t);
-                    t.addSuppressed(ClientInformation.create(client));
-                    lastException = t;
+                    exceptions.add(new ClientException(t.getMessage(), client, t));
+                }
+
+                if (item != null) {
+                    break;
                 }
             }
         } catch (IOException e) {
             throw ExceptionTools.toRuntimeException(e);
         }
 
-        if (lastException != null) {
-            throw ExceptionTools.wrapUnfriendlyExceptions("This video cannot be loaded.", SUSPICIOUS, lastException);
+        if (item == null && !exceptions.isEmpty()) {
+            throw new AllClientsFailedException(exceptions);
         }
 
-        return null;
+        return item;
     }
 
     @Nullable

common/src/main/java/dev/lavalink/youtube/track/YoutubeAudioTrack.java

@@ -13,10 +13,10 @@
 import com.sedmelluq.discord.lavaplayer.track.DelegatedAudioTrack;
 import com.sedmelluq.discord.lavaplayer.track.playback.LocalAudioTrackExecutor;
 import dev.lavalink.youtube.CannotBeLoaded;
+import dev.lavalink.youtube.AllClientsFailedException;
 import dev.lavalink.youtube.ClientInformation;
-import dev.lavalink.youtube.UrlTools;
+import dev.lavalink.youtube.*;
 import dev.lavalink.youtube.UrlTools.UrlInfo;
-import dev.lavalink.youtube.YoutubeAudioSourceManager;
 import dev.lavalink.youtube.cipher.ScriptExtractionException;
 import dev.lavalink.youtube.clients.skeleton.Client;
 import dev.lavalink.youtube.track.format.StreamFormat;
@@ -29,7 +29,9 @@
 import java.io.IOException;
 import java.net.URI;
 import java.net.URISyntaxException;
+import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.List;
 import java.util.Map;
 
 import static com.sedmelluq.discord.lavaplayer.container.Formats.MIME_AUDIO_WEBM;
@@ -84,7 +86,7 @@ public void process(LocalAudioTrackExecutor localExecutor) throws Exception {
         log.debug("Failed to parse token from userData", e);
       }
 
-      Exception lastException = null;
+      List<Throwable> exceptions = new ArrayList<>();
 
       for (Client client : clients) {
         if (!client.supportsFormatLoading()) {
@@ -95,49 +97,16 @@ public void process(LocalAudioTrackExecutor localExecutor) throws Exception {
 
         try {
           processWithClient(localExecutor, httpInterface, client, 0);
-          return; // stream played through successfully, short-circuit.
-        } catch (RuntimeException e) {
-          // store exception so it can be thrown if we run out of clients to
-          // load formats with.
-          e.addSuppressed(ClientInformation.create(client));
-          lastException = e;
-
-          if (e instanceof FriendlyException) {
-            // usually thrown by getPlayabilityStatus when loading formats.
-            // these aren't considered fatal, so we just store them and continue.
-            continue;
-          }
-
-          if (e instanceof ScriptExtractionException) {
-            // If we're still early in playback, we can try another client
-            if (localExecutor.getPosition() <= BAD_STREAM_POSITION_THRESHOLD_MS) {
-              continue;
-            }
-          } else if ("Not success status code: 403".equals(e.getMessage()) ||
-                  "Invalid status code for player api response: 400".equals(e.getMessage())) {
-            // As long as the executor position has not surpassed the threshold for which
-            // a stream is considered unrecoverable, we can try to renew the playback URL with
-            // another client.
-            if (localExecutor.getPosition() <= BAD_STREAM_POSITION_THRESHOLD_MS) {
-              continue;
-            }
-          }
-
-          throw e; // Unhandled exception, just rethrow.
+          return;
+        } catch (CannotBeLoaded e) {
+          throw e;
+        } catch (Exception e) {
+          exceptions.add(new ClientException(e.getMessage(), client, e));
         }
       }
 
-      if (lastException != null) {
-        if (lastException instanceof FriendlyException) {
-          if (!"YouTube WebM streams are currently not supported.".equals(lastException.getMessage())) {
-            // Rethrow certain FriendlyExceptions as suspicious to ensure LavaPlayer logs them.
-            throw new FriendlyException(lastException.getMessage(), Severity.SUSPICIOUS, lastException.getCause());
-          }
-
-          throw lastException;
-        }
-
-        throw ExceptionTools.toRuntimeException(lastException);
+      if (!exceptions.isEmpty()) {
+        throw ExceptionTools.wrapUnfriendlyExceptions("All clients failed to load the track.", Severity.SUSPICIOUS, new AllClientsFailedException(exceptions));
       }
     } catch (CannotBeLoaded e) {
       throw ExceptionTools.wrapUnfriendlyExceptions("This video is unavailable", Severity.SUSPICIOUS, e.getCause());