Skip to content

refactor: use pure gRPC instead of grpc-web wrapper on the provider side #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nimrod-teich wants to merge 5 commits into
base: main
Choose a base branch
from
+1,417 −314
Open

refactor: use pure gRPC instead of grpc-web wrapper on the provider side #2194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7ded98f
refactor(rpcprovider)!: use pure gRPC instead of grpc-web wrapper
nimrod-teich Jan 20, 2026
f596a7d
refactor: remove manual application-level compression
nimrod-teich Jan 20, 2026
0c24a34
refactor: rename compression flag to --enable-grpc-compression
nimrod-teich Jan 20, 2026
daf6566
test: add gRPC compression integration tests
nimrod-teich Jan 20, 2026
88bb60e
fix: handle empty healthCheckPath in provider listener
nimrod-teich Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,7 @@ require (
github.com/rogpeppe/go-internal v1.14.1 // indirect
github.com/sagikazarmark/locafero v0.4.0 // indirect
github.com/sagikazarmark/slog-shim v0.1.0 // indirect
github.com/soheilhy/cmux v0.1.5 // indirect
github.com/sourcegraph/conc v0.3.0 // indirect
github.com/supranational/blst v0.3.13 // indirect
github.com/tidwall/btree v1.6.0 // indirect
Expand Down
3 changes: 3 additions & 0 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,6 +1218,8 @@ github.com/sirupsen/logrus v1.9.3/go.mod h1:naHLuLoDiP4jHNo9R0sCBMtWGeIprob74mVs
github.com/smartystreets/assertions v0.0.0-20180927180507-b2de0cb4f26d/go.mod h1:OnSkiWE9lh6wB0YB77sQom3nweQdgAjqCqsofrRNTgc=
github.com/smartystreets/goconvey v1.6.4/go.mod h1:syvi0/a8iFYH4r/RixwvyeAJjdLS9QV7WQ/tjFTllLA=
github.com/soheilhy/cmux v0.1.4/go.mod h1:IM3LyeVVIOuxMH7sFAkER9+bJ4dT7Ms6E4xg4kGIyLM=
github.com/soheilhy/cmux v0.1.5 h1:jjzc5WVemNEDTLwv9tlmemhC73tI08BNOIGwBOo10Js=
github.com/soheilhy/cmux v0.1.5/go.mod h1:T7TcVDs9LWfQgPlPsdngu6I6QIoyIFZDDC6sNE1GqG0=
github.com/sony/gobreaker v0.4.1/go.mod h1:ZKptC7FHNvhBz7dN2LGjPVBz2sZJmc0/PkyDJOjmxWY=
github.com/sourcegraph/conc v0.3.0 h1:OQTbbt6P72L20UqAkXXuLOj79LfEanQ+YQFNpLA9ySo=
github.com/sourcegraph/conc v0.3.0/go.mod h1:Sdozi7LEKbFPqYX2/J+iBAM6HpqSLTASQIKqDmF7Mt0=
Expand Down Expand Up @@ -1488,6 +1490,7 @@ golang.org/x/net v0.0.0-20201010224723-4f7140c49acb/go.mod h1:sp8m0HH+o8qH0wwXwY
golang.org/x/net v0.0.0-20201021035429-f5854403a974/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
golang.org/x/net v0.0.0-20201031054903-ff519b6c9102/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
golang.org/x/net v0.0.0-20201110031124-69a78807bb2b/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
golang.org/x/net v0.0.0-20201202161906-c7110b5ffcbb/go.mod h1:sp8m0HH+o8qH0wwXwYZr8TS3Oi6o0r6Gce1SSxlDquU=
golang.org/x/net v0.0.0-20201209123823-ac852fbbde11/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
golang.org/x/net v0.0.0-20210119194325-5f4716e94777/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
golang.org/x/net v0.0.0-20210220033124-5f55cee0dc0d/go.mod h1:m0MpNAwzfU5UDzcl9v0D8zg8gWTRqZa9RBIspLL5mdg=
Expand Down
2 changes: 1 addition & 1 deletion protocol/lavasession/consumer_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func (list EndpointInfoList) Swap(i, j int) {

const (
AllowInsecureConnectionToProvidersFlag = "allow-insecure-provider-dialing"
AllowGRPCCompressionFlag = "enable-application-level-compression"
AllowGRPCCompressionFlag = "enable-grpc-compression"
MaximumStreamsOverASingleConnectionFlag = "maximum-streams-per-connection"
DefaultMaximumStreamsOverASingleConnection = 100
WeightMultiplierForStaticProviders = 10
Expand Down
4 changes: 2 additions & 2 deletions protocol/rpcconsumer/rpcconsumer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,7 +478,7 @@ rpcconsumer consumer_examples/full_consumer_example.yml --cache-be "127.0.0.1:77
}
lavasession.AllowGRPCCompressionForConsumerProviderCommunication = viper.GetBool(lavasession.AllowGRPCCompressionFlag)
if lavasession.AllowGRPCCompressionForConsumerProviderCommunication {
utils.LavaFormatInfo("AllowGRPCCompressionForConsumerProviderCommunication is set to true, messages will be compressed", utils.Attribute{Key: lavasession.AllowGRPCCompressionFlag, Value: lavasession.AllowGRPCCompressionForConsumerProviderCommunication})
utils.LavaFormatInfo("gRPC compression enabled, relay messages will use gzip compression", utils.Attribute{Key: lavasession.AllowGRPCCompressionFlag, Value: lavasession.AllowGRPCCompressionForConsumerProviderCommunication})
}

var rpcEndpoints []*lavasession.RPCEndpoint
Expand Down Expand Up @@ -669,7 +669,7 @@ rpcconsumer consumer_examples/full_consumer_example.yml --cache-be "127.0.0.1:77
cmdRPCConsumer.Flags().Uint(common.MaximumConcurrentProvidersFlagName, 3, "max number of concurrent providers to communicate with")
cmdRPCConsumer.MarkFlagRequired(common.GeolocationFlag)
cmdRPCConsumer.Flags().Bool(lavasession.AllowInsecureConnectionToProvidersFlag, false, "allow insecure provider-dialing. used for development and testing")
cmdRPCConsumer.Flags().Bool(lavasession.AllowGRPCCompressionFlag, false, "allow messages to be compressed when communicating between the consumer and provider")
cmdRPCConsumer.Flags().Bool(lavasession.AllowGRPCCompressionFlag, false, "enable gzip compression for gRPC messages between consumer and provider (reduces bandwidth, adds CPU overhead)")
cmdRPCConsumer.Flags().Uint64Var(&lavasession.MaximumStreamsOverASingleConnection, lavasession.MaximumStreamsOverASingleConnectionFlag, lavasession.DefaultMaximumStreamsOverASingleConnection, "maximum number of parallel streams over a single provider connection")
cmdRPCConsumer.Flags().Bool(common.TestModeFlagName, false, "test mode causes rpcconsumer to send dummy data and print all of the metadata in it's listeners")
cmdRPCConsumer.Flags().String(performance.PprofAddressFlagName, "", "pprof server address, used for code profiling")
Expand Down
26 changes: 4 additions & 22 deletions protocol/rpcconsumer/rpcconsumer_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1382,11 +1382,9 @@ func (rpccs *RPCConsumerServer) relayInner(ctx context.Context, singleConsumerSe
common.LAVA_LB_UNIQUE_ID_HEADER: singleConsumerSession.EndpointConnection.GetLbUniqueId(),
})

// Add custom header to indicate compression support if flag is enabled
compressionEnabled := lavasession.AllowGRPCCompressionForConsumerProviderCommunication
if compressionEnabled {
metadataAdd.Set(common.LavaCompressionSupportHeader, "true")
}
// Note: gRPC compression is handled automatically by the gRPC layer
// when AllowGRPCCompressionForConsumerProviderCommunication is enabled
// via grpc.UseCompressor(gzip.Name) in ConnectGRPCClient

utils.LavaFormatTrace("Sending relay to provider",
utils.LogAttr("GUID", ctx),
Expand All @@ -1412,23 +1410,7 @@ func (rpccs *RPCConsumerServer) relayInner(ctx context.Context, singleConsumerSe
reply, err = endpointClient.Relay(connectCtx, relayRequest, grpc.Header(&responseHeader), grpc.Trailer(&relayResult.ProviderTrailer))
relayLatency = time.Since(relaySentTime)

// Check if response is compressed and decompress if needed
appLevelCompressed := false
if lavaCompressionValues := responseHeader.Get(common.LavaCompressionHeader); len(lavaCompressionValues) > 0 {
appLevelCompressed = lavaCompressionValues[0] == common.LavaCompressionGzip
}

if reply != nil && reply.Data != nil && appLevelCompressed {
decompressedData, decompressErr := common.DecompressData(reply.Data)
if decompressErr != nil {
utils.LavaFormatError("Failed to decompress response", decompressErr,
utils.LogAttr("GUID", ctx),
utils.LogAttr("providerName", providerPublicAddress),
)
return nil, 0, decompressErr, false
}
reply.Data = decompressedData
}
// Note: gRPC decompression is handled automatically by the gRPC layer

providerUniqueId := relayResult.ProviderTrailer.Get(chainlib.RpcProviderUniqueIdHeader)
if len(providerUniqueId) > 0 {
Expand Down
Loading
Loading