refactor: rename strategy #2207
Open
+56
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the default selection strategy in the relay processor and related components from Quorum to Stateless. The updates include modifications to the relay state machine, tests, and selection constants to reflect this change. The Stateless selection allows for retries and seeks majority consensus from node responses, enhancing the handling of node errors and improving overall reliability in processing results.
Updated comments for the Stateless and Stateful selection strategies to enhance clarity. The Stateless selection now emphasizes retries and seeking node responses, while the Stateful selection description has been expanded to include waiting for all providers to return a response.
Codecov Report❌ Patch coverage is
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes:
Constant Definitions (selection.go):
Quorum → Stateless - "retries enabled, seeks majority consensus from node responses"
BestResult → Stateful - "all top providers at once, waits for best result (no retries)"
Logic Updates: All comparisons and assignments updated:
selection == Quorum → selection == Stateless
selection == BestResult → selection == Stateful
selection != BestResult → selection != Stateful
Comments Updated: All relevant comments now reference the new names
Tests Updated: All test cases now use the new constant names