chore: add error trigger to smoke test sentry first-party js errors#3086
Open
mugiwaramunyi wants to merge 1 commit intomainfrom
Open
chore: add error trigger to smoke test sentry first-party js errors#3086mugiwaramunyi wants to merge 1 commit intomainfrom
mugiwaramunyi wants to merge 1 commit intomainfrom
Conversation
Test Results380 tests +348 370 ✅ +338 26s ⏱️ +26s Results for commit be03c9d. ± Comparison against base commit 02c8473. This pull request removes 2 and adds 350 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
| } | ||
|
|
||
| const peachJam = new PeachJam(); | ||
| (window as any).peachJam = peachJam; |
Contributor
There was a problem hiding this comment.
Not necessary, this gets done by https://github.com/laws-africa/peachjam/blob/main/peachjam/js/app.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an error trigger in order to sanity test our Sentry third-party JS error filtering