-
Notifications
You must be signed in to change notification settings - Fork 17
Update Academy First Page #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: vr-varad <[email protected]>
Signed-off-by: vr-varad <[email protected]>
Signed-off-by: vr-varad <[email protected]>
It's a fine line between convenience of info and duplication of info (more maintenance) - difficult to navigate. |
<a href="https://github.com/layer5io/academy-theme">academy-theme</a> | ||
provides the core layout, style, and features for your learning path. Regularly updating it ensures you benefit | ||
from | ||
the latest improvements and bug fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we hardcode the latest version?
You can | ||
place custom | ||
Hugo | ||
Shortcodes here if you need special reusable components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems they are listed on one line in your screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which is good. They shouldn't be on multiple lines here, though.... at least not in terms of cleanliness. They render on a the same line, which makes this acceptable.
Signed-off-by: Horti <[email protected]>
Shortcodes here if you need special reusable components. | ||
</li> | ||
</ul> | ||
<h5>Content Hierarchy</h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incomplete.
Either the rest of the content types need to be represented or a note needs to be included to say that this is only part of what is supported and a hyperlink included to Layer5 Docs with the full list.
|
Ya, I agree with you @Vincamine |
Signed-off-by: Varad Gupta <[email protected]>
Notes for Reviewers
This PR updates the first visible page of academy with important info.
Signed commits